Open
Conversation
added 2 commits
March 16, 2017 16:45
Add support for important C3P0 configs. Add convenient function for kylin DB. Add cloverage plugin for test profile. Tests pending.
Member
|
My 2 cents: Make Korma easier to configure with the c3p0 --- and leave the c3p0 configuration to the user... don't attempt to wrap every c3p0 configuration, that's a waste of time/energy. The way I configure my c3p0 pool at work is to just pull the pool off like Then just call the java api on it like:
|
Member
|
This code imho should be two PRs -- it's two different changes smooshed into one branch. |
Member
|
Imho again: connection pool management by Korma is/was a mistake :) If there was ever going to be a Korma 1.0 -- I'd vote for removal of conn management from the api entirely. (Amen there probably should be by now, hehe -- nothing in the Clojure community ever makes it to 1.0.0 :) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for not between and similar to predicates.
Add support for important C3P0 configs.
Add convenient function for kylin DB.
Add cloverage plugin for test profile.