Skip to content

Fix URL extraction when the regex falls short #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lfoppiano merged 9 commits into from
Nov 25, 2024
Merged

Fix URL extraction when the regex falls short #1190

lfoppiano merged 9 commits into from
Nov 25, 2024

Conversation

@lfoppiano
Copy link
Collaborator

@lfoppiano lfoppiano commented Oct 24, 2024

This PR fixes the URL extraction when the regular expression is shorter than the actual target (the annotated URL).

@lfoppiano lfoppiano mentioned this pull request Oct 24, 2024
Closed
@lfoppiano lfoppiano marked this pull request as draft October 24, 2024 11:56
@coveralls
Copy link

coveralls commented Oct 24, 2024 •
edited
Loading

Coverage Status

coverage: 40.768% (+0.01%) from 40.755%
when pulling 35ec905 on fix-url-extraction-regex-shorter
into be44579 on master.

@lfoppiano lfoppiano marked this pull request as ready for review October 26, 2024 04:54
@lfoppiano lfoppiano linked an issue Oct 31, 2024 that may be closed by this pull request
some URLs are not extracted in DAS #1184
Closed
@lfoppiano lfoppiano removed a link to an issue Oct 31, 2024
some URLs are not extracted in DAS #1184
Closed
@lfoppiano lfoppiano linked an issue Nov 8, 2024 that may be closed by this pull request
URLs where the regex capture less than the annotations are not consolidated with the clickable links from the PDF document #1191
Closed
@lfoppiano lfoppiano requested a review from kermitt2 November 12, 2024 17:36
@lfoppiano
Copy link
Collaborator Author

lfoppiano commented Nov 13, 2024 •
edited
Loading

Added a fix for the edge case:

image

Where genius editors are adding the - for breaking up an URL over two lines.

Here the document: https://doi.org/10.1038/s41588-024-01785-9

@lfoppiano lfoppiano self-assigned this Nov 21, 2024
@lfoppiano lfoppiano added this to the 0.8.2 milestone Nov 21, 2024
@lfoppiano lfoppiano merged commit 61162e7 into master Nov 25, 2024
8 checks passed
@lfoppiano lfoppiano deleted the fix-url-extraction-regex-shorter branch November 25, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kermitt2 kermitt2 Awaiting requested review from kermitt2

Assignees

@lfoppiano lfoppiano

Labels

None yet

Projects

None yet

Milestone

0.8.2

Development

Successfully merging this pull request may close these issues.

URLs where the regex capture less than the annotations are not consolidated with the clickable links from the PDF document

4 participants

@lfoppiano @coveralls @Bubblbu