feat: expanded test coverage for Solana, TRON, TON (58 tests)#190
Merged
BitHighlander merged 6 commits intomasterfrom Apr 4, 2026
Merged
feat: expanded test coverage for Solana, TRON, TON (58 tests)#190BitHighlander merged 6 commits intomasterfrom
BitHighlander merged 6 commits intomasterfrom
Conversation
Solana (+11 tests → 23 total): - 4 negative/rejection: malformed, truncated, trailing bytes, oversized - 2 multi-instruction: 2x transfer, transfer+memo - 1 token metadata: SolanaTokenInfo with USDC mint/symbol/decimals - 2 path edge cases: 3-element path, wrong coin type - 1 versioned v0: opaque tx requiring AdvancedMode - 1 already existed: sign_message_blocked_without_advanced_mode TRON (+6 tests → 15 total): - 2 path edge cases: too short (2 levels), wrong coin type - 2 negative: empty raw_data, oversized raw_data - 1 determinism: same raw_data produces same signature - 1 different accounts: different keys produce different signatures TON (+9 tests → 20 total): - 2 path edge cases: too short (2 levels), wrong coin type - 2 negative: empty raw_tx, oversized raw_tx - 2 memo edge cases: empty memo, long memo (255 chars) - 2 workchain: explicit zero, default (verify match) - 1 different accounts: different keys produce different signatures Also: removed duplicate test_tron_show_address and test_ton_show_address
- test_ton_path_too_short: firmware is lenient (accepts 2-level path) - test_ton_path_wrong_coin: firmware rejects wrong coin type (expect CallException) - test_tron_path_wrong_coin: firmware rejects wrong coin type (expect CallException) - test_tron_sign_deterministic: fix assertEqual arity (use assertTrue instead)
1. N5 method name: test_ton_sign_with_comment -> test_ton_sign_with_memo (JUnit match) 2. N4 description: remove false "hash verification" claim, describe actual behavior 3. S12: add token_info metadata test (SolanaTokenInfo with USDC mint/symbol) 4. TON section description: remove cell tree reconstruction claim (deferred to 7.15) 5. TON bullet points: CLEAR-SIGN -> STRUCTURED (accurate for current behavior) 6. S5 description: add AdvancedMode requirement note 7. T4 description: clarify blind sign shows amount+address if provided
…ce + raw_address bug
pastaghost
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands integration test coverage from ~27 to 58 tests across Solana, TRON, and TON.
Solana (+11 tests -> 23 total):
TRON (+6 tests -> 15 total):
TON (+9 tests -> 20 total):
Also removes duplicate test_tron_show_address and test_ton_show_address methods.
Test Plan