Skip to content

fix: guard Ethereum tests with requires_fullFeature#175

Closed
BitHighlander wants to merge 1 commit intomasterfrom
fix/guard-eth-tests-fullfeature
Closed

fix: guard Ethereum tests with requires_fullFeature#175
BitHighlander wants to merge 1 commit intomasterfrom
fix/guard-eth-tests-fullfeature

Conversation

@BitHighlander
Copy link
Copy Markdown
Contributor

@BitHighlander BitHighlander commented Mar 6, 2026

Summary

  • Adds requires_fullFeature() to test_sign_eth_btc_swap and test_sign_eth_add_liquidity in test_msg_mayachain_signtx.py
  • These tests use ethereum_sign_tx which requires full firmware (not BTC-only)
  • Without this guard, they fail against the BTC-only emulator

Test plan

  • Tests skip on BTC-only firmware
  • Tests still pass on full firmware (no change to behavior)

@BitHighlander BitHighlander requested a review from pastaghost March 6, 2026 00:52
BitHighlander added a commit that referenced this pull request Mar 6, 2026
@BitHighlander
fix: combined cleanup (PRs #173, #175, #170, #165)
0b9b573 
- Add WETH to uniswap token database (PR #173)
- Guard Ethereum tests with requires_fullFeature for BTC-only firmware (PR #175)
- Fix shebang lines: /bin/env -> /usr/bin/env (PR #170)
- Add ripple_get_address command to keepkeyctl (PR #165)
@BitHighlander BitHighlander mentioned this pull request Mar 6, 2026
Merged
4 tasks
BitHighlander added a commit that referenced this pull request Mar 6, 2026
@BitHighlander
fix: combined cleanup (PRs #173, #175, #170, #165)
c5cd85a 
- Add WETH to uniswap token database (PR #173)
- Guard Ethereum tests with requires_fullFeature for BTC-only firmware (PR #175)
- Fix shebang lines: /bin/env -> /usr/bin/env (PR #170)
- Add ripple_get_address command to keepkeyctl (PR #165)
@BitHighlander BitHighlander deleted the fix/guard-eth-tests-fullfeature branch March 16, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pastaghost pastaghost Awaiting requested review from pastaghost

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BitHighlander