Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: keepkey/python-keepkey
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: features/7.15
Choose a base ref
...
head repository: keepkey/python-keepkey
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 6 files changed
  • 3 contributors

Commits on Apr 3, 2026

  1. Merge pull request #189 from keepkey/features/7.15

    feat: 7.15 features -- ZcashDisplayAddress, AdvancedMode gates, blind-sign policy
    pastaghost authored Apr 3, 2026
    Configuration menu
    Copy the full SHA
    3d36e92 View commit details
    Browse the repository at this point in the history
  2. feat: expand test coverage for Solana, TRON, TON (58 tests total)

    Solana (+11 tests → 23 total):
    - 4 negative/rejection: malformed, truncated, trailing bytes, oversized
    - 2 multi-instruction: 2x transfer, transfer+memo
    - 1 token metadata: SolanaTokenInfo with USDC mint/symbol/decimals
    - 2 path edge cases: 3-element path, wrong coin type
    - 1 versioned v0: opaque tx requiring AdvancedMode
    - 1 already existed: sign_message_blocked_without_advanced_mode
    
    TRON (+6 tests → 15 total):
    - 2 path edge cases: too short (2 levels), wrong coin type
    - 2 negative: empty raw_data, oversized raw_data
    - 1 determinism: same raw_data produces same signature
    - 1 different accounts: different keys produce different signatures
    
    TON (+9 tests → 20 total):
    - 2 path edge cases: too short (2 levels), wrong coin type
    - 2 negative: empty raw_tx, oversized raw_tx
    - 2 memo edge cases: empty memo, long memo (255 chars)
    - 2 workchain: explicit zero, default (verify match)
    - 1 different accounts: different keys produce different signatures
    
    Also: removed duplicate test_tron_show_address and test_ton_show_address
    BitHighlander committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    ee0c447 View commit details
    Browse the repository at this point in the history
  3. fix: correct test expectations from CI findings

    - test_ton_path_too_short: firmware is lenient (accepts 2-level path)
    - test_ton_path_wrong_coin: firmware rejects wrong coin type (expect CallException)
    - test_tron_path_wrong_coin: firmware rejects wrong coin type (expect CallException)
    - test_tron_sign_deterministic: fix assertEqual arity (use assertTrue instead)
    BitHighlander committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    13233fa View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2026

  1. Configuration menu
    Copy the full SHA
    a5f7eee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    80fad41 View commit details
    Browse the repository at this point in the history
  3. fix: report generator — 11 issues fixed

    1. N5 method name: test_ton_sign_with_comment -> test_ton_sign_with_memo (JUnit match)
    2. N4 description: remove false "hash verification" claim, describe actual behavior
    3. S12: add token_info metadata test (SolanaTokenInfo with USDC mint/symbol)
    4. TON section description: remove cell tree reconstruction claim (deferred to 7.15)
    5. TON bullet points: CLEAR-SIGN -> STRUCTURED (accurate for current behavior)
    6. S5 description: add AdvancedMode requirement note
    7. T4 description: clarify blind sign shows amount+address if provided
    BitHighlander committed Apr 4, 2026
    Configuration menu
    Copy the full SHA
    35be611 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    62cc0d8 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #190 from keepkey/features/7.15-expanded-tests

    feat: expanded test coverage for Solana, TRON, TON (58 tests)
    BitHighlander authored Apr 4, 2026
    Configuration menu
    Copy the full SHA
    a6c6602 View commit details
    Browse the repository at this point in the history
Loading