Support secret refs for Hashicorp Vault token auth in TriggerAuthentication#7571
Open
Kunalbehbud wants to merge 1 commit intokedacore:mainfrom
Open
Support secret refs for Hashicorp Vault token auth in TriggerAuthentication#7571Kunalbehbud wants to merge 1 commit intokedacore:mainfrom
Kunalbehbud wants to merge 1 commit intokedacore:mainfrom
Conversation
Signed-off-by: kunal.behbudzade <[email protected]>
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds secret-based token resolution for Hashicorp Vault authentication in TriggerAuthentication while preserving backward compatibility for existing plain-text configurations.
Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #6026
Relates to kedacore/keda-docs#1724
What changed
spec.hashiCorpVault.credential.tokenFrom.secretKeyRefso Vault token auth can read the token from a Kubernetes Secretspec.hashiCorpVault.credential.tokensupport for backward compatibility, but mark it deprecated via admission warnings and documentationtokenFrom.secretKeyRefbefore constructing the Vault handler for bothTriggerAuthenticationandClusterTriggerAuthenticationBackward compatibility
credential.tokenconfigurations continue to worktokenFrom.secretKeyRefandtokenare set,tokenFrom.secretKeyReftakes precedenceHow it was tested
make generatemake manifestsmake generate-scalers-schemaPATH="$(go env GOPATH)/bin:$PATH" make golangcimake testgo test -tags e2e ./tests/secret-providers/hashicorp_vault -run TestDoesNotExist