Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: greggman/node-github
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: kaanon/node-github
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 6 files changed
  • 3 contributors

Commits on Nov 18, 2014

  1. Adds the upload asset release api

    Here's a first pass at adding this feature. Please tell me if you'd
    like it implemented a different way. Of course I like it as is :P
    but some things to consider
    
    *   Content-Type
    
        Currently I set the content type automatically based on the name
        you pass in. This is a little magic as it assumes there's both
        a `filePath` and `name` field.
    
        It could be required to be set by the user as in
    
            github.releases.uploadAsset({
                owner: owner,
                id: releaseId,
                headers: {
                   "content-type": "application/zip",
                }
                ...
    
        Similarly the size could be manually set there. But, since, based
        on the current API there's no way for us to upload the file (we
        don't get the request object back, and we can't just pass the
        data (it's arguably too big. Could be 100s of meg, more than
        fits in node's memory space), it seems like we should lookup
        the size and stream the file as it does now?
    
    *   Timeout
    
        Wasn't sure what to do about that. Timeouts don't seem appropriate
        for uploading giant files or at least can't easily be a global
        setting.
    
    Anyway, if you don't like this patch hopefully you can suggest a way
    you'd prefer it.
    greggman committed Nov 18, 2014
    Configuration menu
    Copy the full SHA
    2ab003b View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2014

  1. Add in support for a passed in upload url

    Kaanon MacFarlane committed Dec 9, 2014
    Configuration menu
    Copy the full SHA
    6e4169b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1 from kaanon/add-upload-asset

    Add upload asset
    kaanon committed Dec 9, 2014
    Configuration menu
    Copy the full SHA
    5fcc61f View commit details
    Browse the repository at this point in the history
Loading