Skip to content

Change GC's methods from module_function to metaclass methods #9142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 1 commit into from
Dec 30, 2025
Merged

Change GC's methods from module_function to metaclass methods #9142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions core/src/main/java/org/jruby/RubyGC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
import static org.jruby.api.Convert.asBoolean;
import static org.jruby.api.Convert.asFixnum;
import static org.jruby.api.Define.defineModule;
import static org.jruby.runtime.Visibility.*;
import org.jruby.runtime.builtin.IRubyObject;

/**
Expand All @@ -67,7 +66,7 @@ public static RubyModule createGCModule(ThreadContext context) {
return defineModule(context, "GC").defineMethods(context, RubyGC.class);
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject config(ThreadContext context, IRubyObject recv) {
return RubyHash.newHash(
context.runtime,
Expand All @@ -76,7 +75,7 @@ public static IRubyObject config(ThreadContext context, IRubyObject recv) {
);
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject config(ThreadContext context, IRubyObject recv, IRubyObject arg) {
if (arg.isNil()) {
return config(context, recv);
Expand All @@ -89,9 +88,8 @@ public static IRubyObject config(ThreadContext context, IRubyObject recv, IRubyO
throw context.runtime.newArgumentError("ArgumentError");
}
}


@JRubyMethod(module = true, visibility = PRIVATE, optional = 1, checkArity = false)
@JRubyMethod(meta = true, optional = 1, checkArity = false)
public static IRubyObject start(ThreadContext context, IRubyObject recv, IRubyObject[] args) {
Arity.checkArgumentCount(context, args, 0, 1);

Expand All @@ -104,27 +102,27 @@ public static IRubyObject garbage_collect(ThreadContext context, IRubyObject rec
return context.nil;
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject measure_total_time(ThreadContext context, IRubyObject self) {
// JVM just keeps track of this so we do not have a toggle here. If we need to show incremental time
// from a particular point we will need to record time and do some extra math.
return asBoolean(context, measureTotalTime);
}

@JRubyMethod(module = true, name = "measure_total_time=", visibility = PRIVATE)
@JRubyMethod(meta = true, name = "measure_total_time=")
public static IRubyObject measure_total_time_set(ThreadContext context, IRubyObject self, IRubyObject value) {
// JVM just keeps track of this so we do not have a toggle here. If we need to show incremental time
// from a particular point we will need to record time and do some extra math.
measureTotalTime = value.isTrue();
return context.nil;
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject total_time(ThreadContext context, IRubyObject self) {
return asFixnum(context, getCollectionTime());
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject enable(ThreadContext context, IRubyObject recv) {
Ruby runtime = context.runtime;
emptyImplementationWarning(runtime, ID.GC_ENABLE_UNIMPLEMENTED, "GC.enable");
Expand All @@ -133,7 +131,7 @@ public static IRubyObject enable(ThreadContext context, IRubyObject recv) {
return asBoolean(context, old);
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject disable(ThreadContext context, IRubyObject recv) {
Ruby runtime = context.runtime;
emptyImplementationWarning(runtime, ID.GC_DISABLE_UNIMPLEMENTED, "GC.disable");
Expand All @@ -142,19 +140,19 @@ public static IRubyObject disable(ThreadContext context, IRubyObject recv) {
return asBoolean(context, old);
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject stress(ThreadContext context, IRubyObject recv) {
return asBoolean(context, stress);
}

@JRubyMethod(name = "stress=", module = true, visibility = PRIVATE)
@JRubyMethod(name = "stress=", meta = true)
public static IRubyObject stress_set(ThreadContext context, IRubyObject recv, IRubyObject arg) {
emptyImplementationWarning(context.runtime, ID.GC_STRESS_UNIMPLEMENTED, "GC.stress=");
stress = arg.isTrue();
return asBoolean(context, stress);
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject count(ThreadContext context, IRubyObject recv) {
try {
return asFixnum(context, getCollectionCount());
Expand All @@ -163,14 +161,14 @@ public static IRubyObject count(ThreadContext context, IRubyObject recv) {
}
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject auto_compact(ThreadContext context, IRubyObject recv) {
emptyImplementationWarning(context.runtime, ID.GC_ENABLE_UNIMPLEMENTED, "GC.auto_compact");

return asBoolean(context, autoCompact);
}

@JRubyMethod(name = "auto_compact=", module = true, visibility = PRIVATE)
@JRubyMethod(name = "auto_compact=", meta = true)
public static IRubyObject auto_compact_set(ThreadContext context, IRubyObject recv, IRubyObject autoCompact) {
emptyImplementationWarning(context.runtime, ID.GC_ENABLE_UNIMPLEMENTED, "GC.auto_compact=");

Expand All @@ -179,7 +177,7 @@ public static IRubyObject auto_compact_set(ThreadContext context, IRubyObject re
return autoCompact;
}

@JRubyMethod(module = true, visibility = PRIVATE)
@JRubyMethod(meta = true)
public static IRubyObject compact(ThreadContext context, IRubyObject recv) {
emptyImplementationWarning(context.runtime, ID.GC_ENABLE_UNIMPLEMENTED, "GC.compact");

Expand Down