use TearDown bound instead of FnOnce() for effect hooks#62
Merged
jetli merged 2 commits intojetli:mainfrom Mar 19, 2026
Merged
Conversation
Fixes jetli#61. Replaces the old `Destructor: FnOnce() + 'static` bound with `Destructor: TearDown` on use_effect_once, use_effect_update, and use_effect_update_with_deps, so users no longer need to return `|| ()` when there is no cleanup logic.
Owner
|
hi, is this a break change for end user? |
Contributor
Author
|
No. It's strictly more permissive. TearDown is implemented for:
No existing call sites break; they just gain the ability to omit the destructor. Good choice releasing in 0.6.1 I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61