Skip to content

Translation of 01-hello-world #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1H0 merged 2 commits into from
Jan 21, 2020
Merged

Translation of 01-hello-world #4

1H0 merged 2 commits into from
Jan 21, 2020

Conversation

@christianhegedues
Copy link
Member

@christianhegedues christianhegedues commented Jan 12, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jan 12, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 12, 2020 20:16
@claassistantio
Copy link

claassistantio commented Jan 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mka4975
mka4975 reviewed Jan 16, 2020
View reviewed changes
Copy link

@mka4975 mka4975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good translation, the last sentence in 'Summary' should be changed grammatically:
Wir nutzen den Browser als einen Weg um JavaScript auszuführen. Dies ist ein praktischer, da wir online lesen, aber auch nur einer von vielen.

@christianhegedues
Copy link
Member Author

christianhegedues commented Jan 18, 2020

Thank you @mka4975 for the hint.
I changed the sentence grammatically and it should be fine for now.

JoeGab
JoeGab reviewed Jan 20, 2020
View reviewed changes
@1H0 1H0 added the changes requested Waiting for changes and /done from PR author label Jan 20, 2020
@christianhegedues
Copy link
Member Author

christianhegedues commented Jan 20, 2020

/done

@javascript-translate-bot javascript-translate-bot removed the changes requested Waiting for changes and /done from PR author label Jan 20, 2020
@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed and removed review needed Review needed, please approve or request changes labels Jan 21, 2020
@1H0 1H0 added ready to merge and removed needs +1 One more review needed labels Jan 21, 2020
@1H0 1H0 merged commit 9a79134 into javascript-tutorial:master Jan 21, 2020
@christianhegedues christianhegedues deleted the de/01-hello-world branch February 10, 2020 17:08
javascript-translate-bot pushed a commit that referenced this pull request Mar 24, 2020
@aniketkudale
Merge pull request #4 from javascript-tutorial/master
5a71d10 
Updating Repo 27-01-2020
SirCodewright added a commit to SirCodewright/de.javascript.info that referenced this pull request Apr 5, 2020
@SirCodewright @christianhegedues
Review issues / update javascript-tutorial#4
fa2d1aa 
Co-Authored-By: Christian Hegedüs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@JoeGab JoeGab JoeGab left review comments

@mka4975 mka4975 mka4975 left review comments

@1H0 1H0 1H0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@christianhegedues @claassistantio @JoeGab @1H0 @mka4975 @javascript-translate-bot