Skip to content

BCN - Selim Lebbady - #260

Closed
lebbady wants to merge 1 commit into
ironhack-labs:masterfrom
lebbady:master
Closed

BCN - Selim Lebbady#260
lebbady wants to merge 1 commit into
ironhack-labs:masterfrom
lebbady:master

Conversation

@lebbady

@lebbady lebbady commented Oct 23, 2018

Copy link
Copy Markdown

No description provided.

@lebbady lebbady changed the title completed Javascript homework (not bonus) BCN - Selim Lebbady Oct 23, 2018

var driver = "John";
console.log("The driver's name is ",driver);
let navigator = prompt("What's the navigator's name?");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to make your code consistent and use always the same structure, in this case you used always var and here let.

}
else {
console.log("Yo, the navigator goes first definitely");
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing but there's an easier way. JS already knows the order so you can simplify your code only comparing the first two letters of the names and it will knows which goes first. Like that :
`
var hacker1Order = hacker1[0];
var hacker2Order = hacker2[0];

if (hacker1Order < hacker2Order) {
console.log('The driver's name goes first');
} etc....
`

"y":25,
"z":26
};
debugger;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to clean your code once you've finished. But cool, you used the debugger!!

@tawebbcn tawebbcn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you did more than you were asked for because you used a more complicated way to solve the problem!

@tawebbcn tawebbcn closed this Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants