PAR Jihad & Diane - #149
Closed
Dianedel wants to merge 1 commit into
Closed
Conversation
|
|
||
| //Loops | ||
| var str = ""; | ||
| for (var i = 0; i < hacker1.length; i++) { |
There was a problem hiding this comment.
You don't need this, actually you can compare two string just by using the greater > operator, like this :
if (hacker1 < hacker2) {
console.log("The driver's name goes first");
} else if (hacker2 < hacker1) {
console.log("The navigator's name goes first");
} else {
console.log("What?! You both got the same name?");
}You can add a toUpperCase or toLowerCase method so they will be writting the same way otherwise :
"Diane" will be sorted before "arthur".
| var strPalindrome = str.split("").reverse().join(""); | ||
| strCompare.sort() | ||
|
|
||
| if (palindrome = strPalindrome) { |
There was a problem hiding this comment.
Be careful when using the = operator, in your case you are reassinging a value, if you want to compare two value you need to use at least two "==".
For exemple in your code, you are changing the value of palindrome, so the condition will be verified everytime, but if you add a second "=" it will work :)
|
If you want to finish, you can check the split method, it will be helpfull :) Otherwise good job ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eloji9
We didn't get to finish the "lorem ipsum generato" part. We'll try to do it later.