node: Added check for already defined macro NOMINMAX#986
Closed
pmed wants to merge 1 commit intonodejs:v1.xfrom
Closed
node: Added check for already defined macro NOMINMAX#986pmed wants to merge 1 commit intonodejs:v1.xfrom
pmed wants to merge 1 commit intonodejs:v1.xfrom
Conversation
In order to avoid Visual C++ warning C4005 about macro redefinition when node.h is included in other project.
bnoordhuis
pushed a commit
that referenced
this pull request
Feb 27, 2015
In order to avoid Visual C++ warning C4005 about macro redefinition when node.h is included in another project. PR-URL: #986 Reviewed-By: Ben Noordhuis <[email protected]>
Member
|
Thanks Pavel, landed in 4d1fa2c with an amended commit log. |
This was referenced Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid Visual C++ warning C4005 about macro redefinition when node.h is included in other project.