build: reduce tarball size by 8-10%#961
Conversation
Slim the tarballs further by removing examples, documentation and test for third party libraries. Also switch to checkout-index versus archive so we avoid using tar.
|
fwiw, we might want to make sure we're properly
|
|
I'm +1 on all of this and also for removing wrk--as long as we introduce instructions for installing it and/or a check in the I'd like to hear from contributors & TC members who have been around a while because there could be historical or other context that impacts on this. /cc @iojs/tc |
|
+1 |
|
Thanks for the feedback. I'll create an issue to discuss "the bigger question" as well as a PR for removing wrk for review. |
There was a problem hiding this comment.
You can also include testing here.
There was a problem hiding this comment.
Yeah, there's heaps of small stuff that we can start picking off. For now I focused on the bigger folders/items. I can go bananas (as in, do a clean sweep) at a later stage, but I prefer talking about our intentions first.
|
LGTM, no comments. |
|
See #982 for |
|
LGTM, I'll merge this today unless there are objections in the meantime |
Slim the tarballs further by removing examples, documentation and test for third party libraries. Also switch to checkout-index versus archive so we avoid using tar. PR-URL: #961 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
landed @ b8310cb, thanks @jbergstroem! |
5 participants
Slim the tarballs further by removing examples, documentation and test for third party libraries. Also switch to checkout-index versus archive so we avoid using tar.
"Verified" by using a generated tarball to configure, compile and test io.js.
Beyond this, it'll get tricker to further reduce the size. A few things to consider:
make bench-httprequirestools/wrkwhich is bundled (3.9mb) but a lot of benchmarks also assumesabis available. Perhaps dropwrkfrom our bundle and make the same assumption?