feat: add model family in cfg#3255
Merged
mergify[bot] merged 2 commits intoinstructlab:mainfrom Apr 11, 2025
Merged
Conversation
fd8f505 to
f03672e
Compare
f03672e to
9221c50
Compare
9221c50 to
5fe5d83
Compare
5fe5d83 to
f54f607
Compare
f54f607 to
0b55bf3
Compare
0b55bf3 to
6ccd1cd
Compare
6ccd1cd to
8681f1e
Compare
Signed-off-by: Jaideep Rao <[email protected]>
8681f1e to
ffebea4
Compare
ffebea4 to
dc8f7ea
Compare
dc8f7ea to
94ba0ff
Compare
94ba0ff to
90422f7
Compare
90422f7 to
60eb3bd
Compare
booxter
suggested changes
Apr 11, 2025
60eb3bd to
b93b666
Compare
booxter
reviewed
Apr 11, 2025
booxter
reviewed
Apr 11, 2025
b93b666 to
0d3a521
Compare
RobotSail
approved these changes
Apr 11, 2025
Member
RobotSail
left a comment
There was a problem hiding this comment.
LGTM, great work on this @jaideepr97
0d3a521 to
dbfd4bb
Compare
booxter
reviewed
Apr 11, 2025
cdoern
approved these changes
Apr 11, 2025
Contributor
cdoern
left a comment
There was a problem hiding this comment.
besides the few nits left over, LGTM
Signed-off-by: Jaideep Rao <[email protected]>
dbfd4bb to
9496ea7
Compare
booxter
approved these changes
Apr 11, 2025
Contributor
booxter
left a comment
There was a problem hiding this comment.
Thanks for working through the comments. This looks ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the ability to pass a specific model-id to generate, chat and serve. This model id is then resolved out of the config if found, and details like the model-family, path etc are extracted and passed further
This is required to support 3rd party models being used as students, teachers etc in an easy way. The model family value is passed into sdg and appropriate chat template is selected based on what is passed
Checklist:
conventional commits.