Skip to content

fix cannot change context in cli issue#2731

Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom
reidliu41:fix-cannot-change-context-cli
Mar 6, 2025
Merged

fix cannot change context in cli issue#2731
mergify[bot] merged 1 commit intoinstructlab:mainfrom
reidliu41:fix-cannot-change-context-cli

Conversation

@reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Dec 2, 2024 •
edited
Loading

Checklist:

No need the parameter for get_cli_helper_sysprompt. 2729

def get_cli_helper_sysprompt() -> str:
    """
    Returns the system prompt to put the chatbot in CLI helper mode
    """
    return CLI_HELPER_SYS_PROMPT

2730, make sure mode_path is PATH

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Dec 2, 2024
@reidliu41 reidliu41 force-pushed the fix-cannot-change-context-cli branch from 118886d to d52f143 Compare December 2, 2024 09:27
@mergify mergify bot added the ci-failure PR has at least one CI failure label Dec 2, 2024
@reidliu41
fix cannot change context in cli and chat box issue
255424d 
- change CONTEXTS variable and add pathlib.Path to make sure the model_path

Signed-off-by: reid_liu <[email protected]>
@reidliu41 reidliu41 force-pushed the fix-cannot-change-context-cli branch from d52f143 to 255424d Compare December 2, 2024 09:57
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Dec 2, 2024
@reidliu41
Copy link
Contributor Author

reidliu41 commented Dec 3, 2024

@jaideepr97 hi, could you please take a look this one?

@ktam3 ktam3 linked an issue Dec 4, 2024 that may be closed by this pull request
cannot change context in cli #2729
Closed
@reidliu41 reidliu41 mentioned this pull request Dec 11, 2024
Closed
@nathan-weinberg nathan-weinberg requested a review from a team January 10, 2025 17:56
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Feb 4, 2025
@reidliu41 reidliu41 requested a review from a team February 5, 2025 01:44
@booxter booxter mentioned this pull request Feb 24, 2025
Closed
@courtneypacheco
Copy link
Contributor

courtneypacheco commented Mar 6, 2025

Can you take a look @mbestavros ?

mbestavros
mbestavros approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@mbestavros mbestavros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 5130cd2 into instructlab:main Mar 6, 2025
@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Mar 6, 2025
@booxter booxter mentioned this pull request Jun 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@booxter booxter booxter approved these changes

@mbestavros mbestavros mbestavros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cannot change context in cli

4 participants

@reidliu41 @courtneypacheco @booxter @mbestavros