Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: immutable-ruby/immutable-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: immutable-ruby/immutable-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: circ
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Feb 7, 2022

  1. Break circular dependency loops caused by Hash/Vector/Set all requiri… 

    …ng each other

Thanks to Sean Collins for reporting that he was getting the following
warning when using Immutable::Hash:

    immutable-ruby/lib/immutable/vector.rb:2: warning: immutable-ruby/lib/immutable/vector.rb:2: warning: loading in progress, circular require considered harmful - immutable-ruby/lib/immutable/hash.rb

To break the loop, move the definitions of Immutable::Hash,
Immutable::Vector, and Immutable::Set (all of which depend on each
other) into a new file, which is required from hash.rb, vector.rb, and
set.rb, but which doesn't require any of those files itself.
    @alexdowad
    alexdowad committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    e35bf50 View commit details
    Browse the repository at this point in the history
Loading