Skip to content

Generating secrets for Heroku automatically - #369

Open
bmann wants to merge 1 commit into
imgproxy:masterfrom
bmann:bmann-patch-1-add-secret-generator
Open

Generating secrets for Heroku automatically#369
bmann wants to merge 1 commit into
imgproxy:masterfrom
bmann:bmann-patch-1-add-secret-generator

Conversation

@bmann

@bmann bmann commented Apr 1, 2020

Copy link
Copy Markdown

Your deploy to heroku wasn't using the generator: secret. I added that to app.json, and it now does deploy automatically with the secrets filled in.

@DarthSim

DarthSim commented Apr 1, 2020

Copy link
Copy Markdown
Member

Hi,
IMGPROXY_KEY and IMGPROXY_SALT should be hex-encoded. The documentation says the following:

Currently the only supported generator is secret, which generates a pseudo-random string of characters.

A pseudo-random string would most probably not be a hex-encoding compatible one.

@bmann

bmann commented Apr 1, 2020

Copy link
Copy Markdown
Author

@DarthSim I installed it and it worked using this 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants