Skip to content

chore: Change maintainer - #7

Merged
krlmlr merged 4 commits into
mainfrom
f-maint-change
Jun 20, 2023
Merged

chore: Change maintainer#7
krlmlr merged 4 commits into
mainfrom
f-maint-change

Conversation

@krlmlr

@krlmlr krlmlr commented May 29, 2023

Copy link
Copy Markdown
Contributor

Copied from igraph, omitted e-mail addresses.

@codecov

codecov Bot commented May 29, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7 (1cbf8f1) into main (fc8313f) will not change coverage.
The diff coverage is n/a.

❗ Current head 1cbf8f1 differs from pull request most recent head bc09943. Consider uploading reports for the commit bc09943 to get more accurate results

@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            3         3           
=========================================
  Hits             3         3

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

maelle
maelle approved these changes May 29, 2023
View reviewed changes

@maelle maelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many R packages will there be in the igraph organization?

It might make sense to create a pkgdown template package just to store the author URLs in that configuration instead of in individual package's (https://github.com/igraph/rigraph/blob/c3d7c780a8d87113afa0a454274a53c609baa86f/_pkgdown.yml#L241)

@krlmlr

krlmlr commented May 29, 2023

Copy link
Copy Markdown
Contributor Author

Two packages for now. Let's postpone the template until we have four, as by the copy-paste rule.

@szhorvat

szhorvat commented May 29, 2023

Copy link
Copy Markdown
Member

I did not do much here. I feel that we should either remove my name, or include the entire team.

@krlmlr krlmlr changed the title Change maintainer chore: Change maintainer Jun 20, 2023
@krlmlr
krlmlr merged commit bf402af into main Jun 20, 2023
@krlmlr
krlmlr deleted the f-maint-change branch June 20, 2023 08:15
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maelle maelle maelle approved these changes
@szhorvat szhorvat Awaiting requested review from szhorvat
@vtraag vtraag Awaiting requested review from vtraag
+1 more reviewer
@gaborcsardi gaborcsardi gaborcsardi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krlmlr @szhorvat @gaborcsardi @maelle