This repository was archived by the owner on Feb 24, 2023. It is now read-only.
Instantiate ListOpts - #5
Merged
Merged
Conversation
Contributor
Author
|
@ibuildthecloud Would you mind tagging a v0.1.2 after this commit? |
Owner
|
@bcwaldon I guess this goes to show why its a good idea to include your deps. Tagged v0.1.2. |
Contributor
Author
|
Yep. Now if only we could reasonably vendor godep itself...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, compiling and running systemd-docker using the vendored deps right now results in a panic. Apparently, I ended up inadvertently vendoring in a newer version of
github.com/docker/docker/optsthan was used to build systemd-docker originally. This upstream commit [0] is the culprit. Updating the usage of ListOpts fixes the panic.[0] moby/moby@6200002