Skip to content
This repository was archived by the owner on Feb 24, 2023. It is now read-only.

Bump client API version to 1.12 - #34

Merged
ibuildthecloud merged 1 commit into
ibuildthecloud:masterfrom
emmetog:master
Sep 9, 2015
Merged

Bump client API version to 1.12#34
ibuildthecloud merged 1 commit into
ibuildthecloud:masterfrom
emmetog:master

Conversation

@emmetog

@emmetog emmetog commented Jul 27, 2015

Copy link
Copy Markdown
Contributor

I'm not sure how to run the tests to see if this change breaks anything, my attempts so far gave me this:

$ go test main.go 
main.go:18:2: cannot find package "github.com/docker/docker/opts" in any of:
    /usr/lib/go/src/pkg/github.com/docker/docker/opts (from $GOROOT)
    ($GOPATH not set)
main.go:19:2: cannot find package "github.com/docker/docker/pkg/mflag" in any of:
    /usr/lib/go/src/pkg/github.com/docker/docker/pkg/mflag (from $GOROOT)
    ($GOPATH not set)
main.go:21:2: cannot find package "github.com/fsouza/go-dockerclient" in any of:
    /usr/lib/go/src/pkg/github.com/fsouza/go-dockerclient (from $GOROOT)
    ($GOPATH not set)

If you can point me in the direction of running the tests I'll run them and try to fix them if necessary. I've zero experience of go though, so please bear with me.

@izaakschroeder

izaakschroeder commented Jul 29, 2015

Copy link
Copy Markdown

👍 from me. This appears to work with docker 1.8-dev and ECS. You can test it yourself by using:

go get github.com/emmetog/systemd-docker

And then using the resulting binary.

@emmetog

emmetog commented Jul 29, 2015

Copy link
Copy Markdown
Contributor Author

Thanks @izaakschroeder.
Yes I rebuilt the binary from my fork a few days ago and I've been using it since then, I haven't run into any problems.
The reason I mentioned the tests was because the other day I saw a file or directory called test and I thought there were unit tests but I wasn't sure how to run them.

@clehene

clehene commented Aug 13, 2015

Copy link
Copy Markdown
Contributor

Now that 1.8.0 was released this is required.

@ibuildthecloud this seems largely stagnant. Is there a better alternative in https://github.com/rancher ?

@smashwilson smashwilson mentioned this pull request Aug 21, 2015
Merged
@hinnerk hinnerk mentioned this pull request Aug 24, 2015
Merged
@pierreozoux

pierreozoux commented Sep 9, 2015

Copy link
Copy Markdown

+1 for the merge! I now use a local fork.

@larsdecker

larsdecker commented Sep 9, 2015

Copy link
Copy Markdown

Please merge it and push a Update to Dockerhub.

@djmaze

djmaze commented Sep 9, 2015

Copy link
Copy Markdown

+1, please merge. Had a cluster break because of this just today.

ibuildthecloud added a commit that referenced this pull request Sep 9, 2015
@ibuildthecloud
Merge pull request #34 from emmetog/master
9b02cf9 
Bump client API version to 1.12
@ibuildthecloud
ibuildthecloud merged commit 9b02cf9 into ibuildthecloud:master Sep 9, 2015
@ibuildthecloud

ibuildthecloud commented Sep 9, 2015

Copy link
Copy Markdown
Owner

I have pushed v0.2.1 that should include this fix. Can somebody test it out? Once I get some positive response that it works I'll tag it as latest. Also please read: #35

@Ulexus Ulexus mentioned this pull request Sep 10, 2015
Closed
@SerialVelocity

SerialVelocity commented May 26, 2017

Copy link
Copy Markdown

@ibuildthecloud Yes, it works :) It was a bit weird that it was tagged as v0.2.1 instead of 0.2.1 though

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

8 participants

@emmetog @izaakschroeder @clehene @pierreozoux @larsdecker @djmaze @ibuildthecloud @SerialVelocity