fix: Mark date parameter as optional in timezone plugin#2222
Merged
iamkun merged 1 commit intoiamkun:devfrom Feb 11, 2023
Merged
fix: Mark date parameter as optional in timezone plugin#2222iamkun merged 1 commit intoiamkun:devfrom
date parameter as optional in timezone plugin#2222iamkun merged 1 commit intoiamkun:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2222 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 181 183 +2
Lines 2074 2109 +35
Branches 544 555 +11
=========================================
+ Hits 2074 2109 +35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Owner
|
Thanks |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 2, 2023
## [1.11.8](v1.11.7...v1.11.8) (2023-06-02) ### Bug Fixes * .format add padding to 'YYYY' ([#2231](#2231)) ([00c223b](00c223b)) * Added .valueOf method to Duration class ([#2226](#2226)) ([9b4fcfd](9b4fcfd)) * timezone type mark `date` parameter as optional ([#2222](#2222)) ([b87aa0e](b87aa0e)) * type file first parameter date is optional in isSame(), isBefore(), isAfter() ([#2272](#2272)) ([4d56f3e](4d56f3e))
|
🎉 This PR is included in version 1.11.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ohsory1324
pushed a commit
to ohsory1324/dayjs
that referenced
this pull request
Dec 20, 2023
ohsory1324
pushed a commit
to ohsory1324/dayjs
that referenced
this pull request
Dec 20, 2023
## [1.11.8](iamkun/dayjs@v1.11.7...v1.11.8) (2023-06-02) ### Bug Fixes * .format add padding to 'YYYY' ([iamkun#2231](iamkun#2231)) ([00c223b](iamkun@00c223b)) * Added .valueOf method to Duration class ([iamkun#2226](iamkun#2226)) ([9b4fcfd](iamkun@9b4fcfd)) * timezone type mark `date` parameter as optional ([iamkun#2222](iamkun#2222)) ([b87aa0e](iamkun@b87aa0e)) * type file first parameter date is optional in isSame(), isBefore(), isAfter() ([iamkun#2272](iamkun#2272)) ([4d56f3e](iamkun@4d56f3e))
This was referenced May 24, 2024
This was referenced Jul 27, 2024
This was referenced Sep 8, 2024
This was referenced Sep 12, 2024
This was referenced Sep 17, 2024
splashwizard
pushed a commit
to splashwizard/tracking-time
that referenced
this pull request
Oct 21, 2024
## [1.11.8](iamkun/dayjs@v1.11.7...v1.11.8) (2023-06-02) ### Bug Fixes * .format add padding to 'YYYY' ([#2231](iamkun/dayjs#2231)) ([00c223b](iamkun/dayjs@00c223b)) * Added .valueOf method to Duration class ([#2226](iamkun/dayjs#2226)) ([9b4fcfd](iamkun/dayjs@9b4fcfd)) * timezone type mark `date` parameter as optional ([#2222](iamkun/dayjs#2222)) ([b87aa0e](iamkun/dayjs@b87aa0e)) * type file first parameter date is optional in isSame(), isBefore(), isAfter() ([#2272](iamkun/dayjs#2272)) ([4d56f3e](iamkun/dayjs@4d56f3e))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LIke
dayjs(),dayjs.tz()falls back to the default time internally if no parameter is passed. But the current Typescript types do not allow for this existing, expected, and correct functionality.