Adds a missing clippy allow#663
Merged
jsturtevant merged 1 commit intohyperlight-dev:mainfrom Jun 26, 2025
Merged
Conversation
jsturtevant
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
It also add a simple function on the roundtrip wit that triggers the clippy failure as a way to test that clippy is fixed Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
fix-unused-int
branch
from
3574fdf to
01ca18b
Compare
syntactically
approved these changes
Jun 26, 2025
Member
syntactically
left a comment
syntactically
left a comment
There was a problem hiding this comment.
LGTM. Thanks @jsturtevant!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #653
It also add a simple function on the roundtrip wit that triggers the clippy failure as a way to test that clippy is fixed and doesn't regress