Skip to content

Support for custom contexts in ContextCommand #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugsy merged 8 commits into from
Sep 27, 2021
Merged

Support for custom contexts in ContextCommand #727

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0c4c19f
added support for external context panes
mahaloz Sep 25, 2021
a5e31a3
fixed a trailing space in settings
mahaloz Sep 25, 2021
30d52e0
fix for review from @hugsy
mahaloz Sep 26, 2021
887d636
fixed format string usage
mahaloz Sep 26, 2021
231cdb7
added ability for dynamic titles and updated api documentation
mahaloz Sep 26, 2021
702dce7
review fix 2
mahaloz Sep 26, 2021
2651de9
Apply suggestions from code review
mahaloz Sep 27, 2021
ff96615
Apply suggestions from code review
mahaloz Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed format string usage 
Co-authored-by: hugsy <[email protected]>
  • Loading branch information
@mahaloz @hugsy
mahaloz and hugsy authored Sep 26, 2021
commit 887d63641066fee2727cfa3e33b5e35f3ca401f2
2 changes: 1 addition & 1 deletion gef.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10694,7 +10694,7 @@ def add_context_pane(self, pane_name, pane_function):
# assure users can toggle the new context
corrected_settings_name = pane_name.replace(" ", "_")
layout_settings = context_obj.get_setting("layout")
context_obj.update_setting("layout", layout_settings+f" {corrected_settings_name}")
context_obj.update_setting("layout", "{} {}".format(layout_settings, corrected_settings_name))

# overload the printing of pane title
context_obj.layout_mapping[corrected_settings_name] = (pane_function, pane_name)
Expand Down