templates/statefulset.yaml (1)

5-7: ⚡ Quick win

Use name-based PVC template lookup instead of index 0.

index $existingVolumeClaimTemplates 0 assumes the first template is always data. If another template is added/reordered, this can pull the wrong labels and trigger immutable StatefulSet update failures again. Match by metadata.name: data before extracting labels.

Proposed change

 {{- $existingVolumeClaimTemplates := dig "spec" "volumeClaimTemplates" (list) $existingStatefulSet -}}
-{{- if gt (len $existingVolumeClaimTemplates) 0 -}}
-{{- $volumeClaimTemplateLabels = dig "metadata" "labels" (dict) (index $existingVolumeClaimTemplates 0) -}}
-{{- end -}}
+{{- range $tpl := $existingVolumeClaimTemplates -}}
+{{- if eq (dig "metadata" "name" "" $tpl) "data" -}}
+{{- $volumeClaimTemplateLabels = dig "metadata" "labels" (dict) $tpl -}}
+{{- end -}}
+{{- end -}}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@templates/statefulset.yaml` around lines 5 - 7, The code uses index
$existingVolumeClaimTemplates 0 to grab labels which assumes the first PVC
template is the data PVC; change this to search $existingVolumeClaimTemplates
for the template whose metadata.name equals "data" and then set
$volumeClaimTemplateLabels from that found item (instead of using index 0).
Specifically, replace the index lookup with logic that iterates or filters
$existingVolumeClaimTemplates to find the entry with metadata.name == "data" and
only then call dig "metadata" "labels" on that item to populate
$volumeClaimTemplateLabels, leaving dig and $existingVolumeClaimTemplates
variable names intact.