Skip to content

Upgrade recovery service backup sdk version from 2023-02-01 to 2024-10-01#29144

Merged
stephybun merged 4 commits intohashicorp:mainfrom
jiaweitao001:upgrade_recovery_service_backup_sdk_version
Mar 31, 2025
Merged

Upgrade recovery service backup sdk version from 2023-02-01 to 2024-10-01#29144
stephybun merged 4 commits intohashicorp:mainfrom
jiaweitao001:upgrade_recovery_service_backup_sdk_version

Conversation

@jiaweitao001
Copy link
Collaborator

@jiaweitao001 jiaweitao001 commented Mar 21, 2025 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

New sdk version 2024-10-01 has been released for recovery service backup, it supports more features.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@jiaweitao001 jiaweitao001 requested a review from a team as a code owner March 21, 2025 06:52
@jiaweitao001 jiaweitao001 changed the title Upgrade recovery service backup sdk version to 2014-10-01 Upgrade recovery service backup sdk version to 2024-10-01 Mar 21, 2025
@jiaweitao001 jiaweitao001 changed the title Upgrade recovery service backup sdk version to 2024-10-01 Upgrade recovery service backup sdk version from 2023-02-01 to 2024-10-01 Mar 21, 2025
@jiaweitao001 jiaweitao001 mentioned this pull request Mar 21, 2025
Closed
1 task
stephybun
stephybun suggested changes Mar 26, 2025
View reviewed changes
internal/services/recoveryservices/backup_policy_file_share_resource.go Outdated
}
}

func resourceBackupProtectionPolicyFileShareDelete(d *pluginsdk.ResourceData, meta interface{}) error {
Copy link
Member

@stephybun stephybun Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this back to where it was before, the CRUD methods should always be grouped together and not inter-spaced with expand or other functions.

Copy link
Collaborator Author

@jiaweitao001 jiaweitao001 Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. The original intention was to avoid false alarm of run-gradually-deprecated.sh. I'll put it back above read function to avoid it.

internal/services/recoveryservices/backup_policy_file_share_resource.go Outdated
}

if _, err := client.CreateOrUpdate(ctx, id, policy); err != nil {
if _, err := client.CreateOrUpdate(ctx, id, policy, protectionpolicies.CreateOrUpdateOperationOptions{}); err != nil {
Copy link
Member

@stephybun stephybun Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can call the default function to return the default options instead of sending an empty opts struct:

Suggested change
if _, err := client.CreateOrUpdate(ctx, id, policy, protectionpolicies.CreateOrUpdateOperationOptions{}); err != nil {
if _, err := client.CreateOrUpdate(ctx, id, policy, protectionpolicies.DefaultCreateOrUpdateOperationOptions()); err != nil {

Can you please make this change for all the other methods that were updated

Copy link
Collaborator Author

@jiaweitao001 jiaweitao001 Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

stephybun
stephybun approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiaweitao001 LGTM 👍

@stephybun stephybun merged commit 840aa45 into hashicorp:main Mar 31, 2025
32 checks passed
@github-actions github-actions bot added this to the v4.26.0 milestone Mar 31, 2025
stephybun added a commit that referenced this pull request Apr 4, 2025
@stephybun
Update for #29217 #29144 #29145
72f8dac
jackofallops added a commit that referenced this pull request Apr 4, 2025
@jackofallops @sreallymatt
@catriona-m @wyattfry @mbfrahry @WodansSon @stephybun
new changelog for 4.26.0 (#29213)
addf136 
* new changelog for 4.26.0

* Update CHANGELOG.md #29212

* Update CHANGELOG.md #28786

* Update CHANGELOG.md for #29095

* Update CHANGELOG.md #29225

* Update CHANGELOG.md #29168

* Update CHANGELOG.md #28890

* Update CHANGELOG.md for #28689

* Update CHANGELOG.md #28354

* Update CHANGELOG.md #29240

* Update CHANGELOG.md for #29211

* Update CHANGELOG.md #29214

* Update CHANGELOG.md for #29209

* Update CHANGELOG.md for 28690

* Update CHANGELOG.md for #28577

* Update for #29217 #29144 #29145

* Update CHANGELOG.md for #29185

* prep for release

---------

Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: stephybun <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stephybun stephybun stephybun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stephybun stephybun

Labels

dependencies enhancement service/recovery-services size/L

Projects

None yet

Milestone

v4.26.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jiaweitao001 @stephybun @katbyte