Upgrade DevCenter API version from 2023-04-01 to 2025-02-01 by neil-yechenwei · Pull Request #29145 · hashicorp/terraform-provider-azurerm

neil-yechenwei · 2025-03-21T07:07:11Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to upgrade DevCenter API version from 2023-04-01 to 2025-02-01 for supporting new features what users expect.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

TestAccDevCenterAttachedNetwork_:

TestAccDevCenterCatalogs_:

TestAccDevCenterDevBoxDefinition_:

TestAccDevCenterEnvironmentType_:

TestAccDevCenterGallery_:

TestAccDevCenterNetworkConnection_:
Below failed test case is also failed with same error on Teamcity Daily Run. So it's not related with this PR.

TestAccDevCenterProjectEnvironmentType_:

TestAccDevCenterProjectPool_:

TestAccDevCenterProject_:
Below failed test case is also failed with same error on Teamcity Daily Run. So it's not related with this PR.

TestAccDevCenter_:

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

Upgrade DevCenter API version from 2023-04-01 to 2025-02-01

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…sion

stephybun

Thanks @neil-yechenwei. In addition to the comments can you also open a PR on https://github.com/hashicorp/pandora to disable the generation of these resources?

stephybun · 2025-03-26T08:29:12Z

internal/services/devcenter/client/client_gen.go

Can you please remove the _gen suffix from the file? Otherwise it might lead to confusion about whether this is still being managed by Pandora or not.

See below suggestion.

stephybun · 2025-03-26T08:29:37Z

internal/services/devcenter/dev_center_project_resource_gen.go

See below suggestion.

stephybun · 2025-03-26T08:29:45Z

internal/services/devcenter/dev_center_project_resource_gen_test.go

See below suggestion.

stephybun · 2025-03-26T08:29:52Z

internal/services/devcenter/dev_center_resource_gen.go

See below suggestion.

stephybun · 2025-03-26T08:30:00Z

internal/services/devcenter/dev_center_resource_gen_test.go

See below suggestion.

neil-yechenwei · 2025-03-27T00:53:45Z

Hi @stephybun , I remember you mentioned before that a PR should only do one thing. This PR is solely for upgrading the API version. So I suggest removing the _gen suffix in another separate PR. Moreover, once these files are modified, I need to rerun the related test cases to ensure there are no regression issues. This takes a lot of time because I encountered quota issues during testing in TeamCity. I have to split the test cases to run them separately in order to pass. Does it make sense?

stephybun · 2025-03-27T07:36:05Z

@neil-yechenwei I would suggest opening a PR to rename those files first then. The point of the _gen suffix in the filename is to indicate to maintainers and contributors that these files are not supposed to be modified because any changes will be overwritten.

neil-yechenwei · 2025-03-27T10:10:21Z

@stephybun ,

I submitted pandora PR 4725 to disable auto gen for Dev Center.
I submitted PR 29202 to rename files with _gen suffix for Dev Center.

neil-yechenwei · 2025-04-01T03:33:26Z

@stephybun , I merged latest changes. Below is the test result that I just now triggered. Please take another look. Thanks.

TestAccDevCenterAttachedNetwork_:

TestAccDevCenterCatalogs_:

TestAccDevCenterDevBoxDefinition_:

TestAccDevCenterEnvironmentType_:

TestAccDevCenterGallery_:

TestAccDevCenterNetworkConnection_:

--- PASS: TestAccDevCenterNetworkConnection_complete (1059.21s)
--- PASS: TestAccDevCenterNetworkConnection_update (1765.59s)
--- PASS: TestAccDevCenterNetworkConnection_basic (1014.59s)
--- PASS: TestAccDevCenterNetworkConnection_requiresImport (985.33s)

TestAccDevCenterProjectEnvironmentType_:

TestAccDevCenterProjectPool_:

TestAccDevCenterProject_:

TestAccDevCenter_:

stephybun

Thanks @neil-yechenwei LGTM 👍

* new changelog for 4.26.0 * Update CHANGELOG.md #29212 * Update CHANGELOG.md #28786 * Update CHANGELOG.md for #29095 * Update CHANGELOG.md #29225 * Update CHANGELOG.md #29168 * Update CHANGELOG.md #28890 * Update CHANGELOG.md for #28689 * Update CHANGELOG.md #28354 * Update CHANGELOG.md #29240 * Update CHANGELOG.md for #29211 * Update CHANGELOG.md #29214 * Update CHANGELOG.md for #29209 * Update CHANGELOG.md for 28690 * Update CHANGELOG.md for #28577 * Update for #29217 #29144 #29145 * Update CHANGELOG.md for #29185 * prep for release --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: Wodans Son <[email protected]> Co-authored-by: stephybun <[email protected]>

github-actions · 2025-05-04T02:27:49Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Upgrade DevCenter API version from 2024-05-01 to 2025-02-01

8bfbfbf

neil-yechenwei requested a review from a team as a code owner March 21, 2025 07:07

github-actions bot added dependencies service/dev-center size/XL enhancement labels Mar 21, 2025

use pointer.from

c17c9a8

neil-yechenwei marked this pull request as draft March 21, 2025 13:03

neil-yechenwei added 3 commits March 25, 2025 09:38

Merge remote-tracking branch 'upstream/main' into upgradedevcenterver…

66df8e5

…sion

update image resource id

5cd2439

Merge remote-tracking branch 'upstream/main' into upgradedevcenterver…

ff1a171

…sion

neil-yechenwei marked this pull request as ready for review March 25, 2025 11:08

stephybun suggested changes Mar 26, 2025

View reviewed changes

github-actions bot assigned stephybun Mar 26, 2025

github-actions bot added the waiting-response label Mar 26, 2025

github-actions bot removed the waiting-response label Mar 27, 2025

neil-yechenwei requested a review from stephybun March 27, 2025 00:59

neil-yechenwei marked this pull request as draft March 27, 2025 11:21

neil-yechenwei added 2 commits April 1, 2025 10:11

merge latest change

d846406

remove test step for recreation

aab7829

neil-yechenwei marked this pull request as ready for review April 1, 2025 13:48

stephybun approved these changes Apr 3, 2025

View reviewed changes

stephybun merged commit 70cf3ff into hashicorp:main Apr 3, 2025
30 checks passed

github-actions bot added this to the v4.26.0 milestone Apr 3, 2025

stephybun added a commit that referenced this pull request Apr 4, 2025

Update for #29217 #29144 #29145

72f8dac

github-actions bot locked as resolved and limited conversation to collaborators May 4, 2025

Conversation

neil-yechenwei commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

neil-yechenwei commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephybun commented Mar 27, 2025

Uh oh!

neil-yechenwei commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neil-yechenwei commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

neil-yechenwei commented Mar 21, 2025 •

edited

Loading

neil-yechenwei commented Mar 27, 2025 •

edited

Loading

neil-yechenwei commented Mar 27, 2025 •

edited

Loading

neil-yechenwei commented Apr 1, 2025 •

edited

Loading