Skip to content

azurerm_key_vault_certificate: set partial when updating key vault certificate#28848

Merged
mbfrahry merged 2 commits intohashicorp:mainfrom
wuxu92:cert/fix-partial-update-issue-28812
Feb 28, 2025
Merged

azurerm_key_vault_certificate: set partial when updating key vault certificate#28848
mbfrahry merged 2 commits intohashicorp:mainfrom
wuxu92:cert/fix-partial-update-issue-28812

Conversation

@wuxu92
Copy link
Collaborator

@wuxu92 wuxu92 commented Feb 24, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The certificate block can not be set in Read function as it's not reponded by API, so if one updating on the certificate failed, the content from configuration will be set to state as well, but subsequent terraform apply with refresh cannot reset the wrong set certificate block, which described in issue #28812.

By setting partial as true in Update, the subsequent terraform apply will keep the drift as expected:

image

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28812

@wuxu92 wuxu92 requested a review from a team as a code owner February 24, 2025 05:11
@wuxu92 wuxu92 changed the title set partial when updating key vault certificate azurerm_key_vault_certificate: set partial when updating key vault certificate Feb 24, 2025
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wuxu92, this change looks good but the wording is a little off! Let me know if the changes I've suggested make sense

Co-authored-by: Matthew Frahry <[email protected]>
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @wuxu92

@mbfrahry mbfrahry merged commit d7437ff into hashicorp:main Feb 28, 2025
31 checks passed
@mbfrahry mbfrahry added this to the v4.22.0 milestone Feb 28, 2025
mbfrahry added a commit that referenced this pull request Feb 28, 2025
@wuxu92 wuxu92 deleted the cert/fix-partial-update-issue-28812 branch March 2, 2025 22:20
jackofallops added a commit that referenced this pull request Mar 7, 2025
* Update CHANGELOG.md #28843

* Update CHANGELOG.md for #28748

* Update CHANGELOG.md for #28881

* Update CHANGELOG.md for #28909

* Update CHANGELOG.md fold in patch release and expand starred entry correctly

* Update CHANGELOG.md remove duplicate entry for 28843

* Update CHANGELOG.md #28066

* Update CHANGELOG.md for #28902 and fix ordering

* Update CHANGELOG.md for #28848

* Update CHANGELOG.md #27622

* Update CHANGELOG.md for #28271

* Update CHANGELOG.md update format

* Update CHANGELOG.md #28934

* Update for #28619 #28598

* Update CHANGELOG.md #28940

* Update CHANGELOG.md for #28880

* Update CHANGELOG.md for #28617

* Update CHANGELOG.md #28721

* Update CHANGELOG.md #28949

* Update previous entry for 4.16.0

* Update CHANGELOG.md for #28834

* prep for release

---------

Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: jackofallops <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurerm_key_vault_certificate updates state but not resource after conflict error

3 participants