`azurerm_express_route_circuit` - add support for the `rate_limiting_enabled` property by bubbletroubles · Pull Request #28659 · hashicorp/terraform-provider-azurerm

bubbletroubles · 2025-02-01T00:21:49Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Added support for setting the ExpressRoute Direct Rate Limiting property

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Test results:

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_express_route_circuit - add support for the rate_limiting_enabled property [azurerm_express_route_circuit - add support for the rate_limiting_enabled property #28659]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

catriona-m

Hi @bubbletroubles thanks for submitting this. I left one minor comment inline but otherwise this is looking good. Thanks!

internal/services/network/express_route_circuit_resource.go

catriona-m

Thanks @bubbletroubles - after taking another look at this I noticed we are only setting the property in the update func at the minute, this would also need to be set in the create. Thanks!

internal/services/network/express_route_circuit_resource.go

catriona-m

Thanks @bubbletroubles LGTM!

* CHANGELOG.md for v4.19.0 * Update CHANGELOG.md #28523 * Update CHANGELOG.md #28691 * Updated to include #28717 * Update for #26680 * Update CHANGELOG.md #28633 * Update CHANGELOG.md for #28703 * Update CHANGELOG.md for #28391 * Update CHANGELOG.md #28725 * Update #28733 * Update CHANGELOG.md #28659 * Update for #28741 * Update CHANGELOG.md #28712 * Update CHANGELOG.md #28441 * Update CHANGELOG.md #28441 * Update CHANGELOG.md #28441 * Update CHANGELOG.md for #28602 * Update for #27424 * Update CHANGELOG.md for #28524 * Update CHANGELOG.md #28726 * Update for #28767 * Update for #28195 * prep for release v4.19.0 --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Wodans Son <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>

…enabled` property (hashicorp#28659) * ER Direct Rate Limiting * formatting * typo * Update express_route_circuit.html.markdown * lf * added docs * ports * Updated docs * Changed from `enable_rate_limiting` to `rate_limiting_enabled` * linting * added on create * typo --------- Co-authored-by: BubbleTroubles <[email protected]>

* CHANGELOG.md for v4.19.0 * Update CHANGELOG.md hashicorp#28523 * Update CHANGELOG.md hashicorp#28691 * Updated to include hashicorp#28717 * Update for hashicorp#26680 * Update CHANGELOG.md hashicorp#28633 * Update CHANGELOG.md for hashicorp#28703 * Update CHANGELOG.md for hashicorp#28391 * Update CHANGELOG.md hashicorp#28725 * Update hashicorp#28733 * Update CHANGELOG.md hashicorp#28659 * Update for hashicorp#28741 * Update CHANGELOG.md hashicorp#28712 * Update CHANGELOG.md hashicorp#28441 * Update CHANGELOG.md hashicorp#28441 * Update CHANGELOG.md hashicorp#28441 * Update CHANGELOG.md for hashicorp#28602 * Update for hashicorp#27424 * Update CHANGELOG.md for hashicorp#28524 * Update CHANGELOG.md hashicorp#28726 * Update for hashicorp#28767 * Update for hashicorp#28195 * prep for release v4.19.0 --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Wodans Son <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>

github-actions · 2025-03-14T02:15:43Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

BubbleTroubles and others added 8 commits January 31, 2025 22:48

ER Direct Rate Limiting

8af078e

formatting

b831750

typo

5db3e13

Update express_route_circuit.html.markdown

41a4c02

lf

6bbdf5a

added docs

916fe5f

ports

911cbbc

Updated docs

a47fb15

github-actions bot added enhancement documentation service/network size/XS labels Feb 1, 2025

bubbletroubles marked this pull request as ready for review February 1, 2025 00:30

bubbletroubles requested a review from a team as a code owner February 1, 2025 00:30

catriona-m requested changes Feb 3, 2025

View reviewed changes

internal/services/network/express_route_circuit_resource.go Outdated Show resolved Hide resolved

github-actions bot assigned catriona-m Feb 3, 2025

github-actions bot added the waiting-response label Feb 3, 2025

bubbletroubles changed the title ~~azurerm_express_route_circuit - add support for the enable_rate_limiting property~~ azurerm_express_route_circuit - add support for the rate_limiting_enabled property Feb 3, 2025

Changed from enable_rate_limiting to rate_limiting_enabled

e7b5ea3

github-actions bot added waiting-response and removed waiting-response labels Feb 3, 2025

linting

530306b

github-actions bot removed the waiting-response label Feb 3, 2025

bubbletroubles requested a review from catriona-m February 3, 2025 11:14

catriona-m requested changes Feb 4, 2025

View reviewed changes

internal/services/network/express_route_circuit_resource.go Show resolved Hide resolved

github-actions bot added the waiting-response label Feb 4, 2025

added on create

0c4e6ee

github-actions bot added waiting-response and removed waiting-response labels Feb 5, 2025

typo

3937af4

github-actions bot removed the waiting-response label Feb 5, 2025

bubbletroubles requested a review from catriona-m February 5, 2025 11:43

catriona-m approved these changes Feb 11, 2025

View reviewed changes

catriona-m merged commit da7d89c into hashicorp:main Feb 11, 2025
34 checks passed

github-actions bot added this to the v4.19.0 milestone Feb 11, 2025

catriona-m added a commit that referenced this pull request Feb 11, 2025

Update CHANGELOG.md #28659

e201048

github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_express_route_circuit` - add support for the `rate_limiting_enabled` property#28659

`azurerm_express_route_circuit` - add support for the `rate_limiting_enabled` property#28659
catriona-m merged 12 commits intohashicorp:mainfrom
bubbletroubles:er-limit-bandwidth

bubbletroubles commented Feb 1, 2025 •

edited

Loading

Uh oh!

catriona-m left a comment

Uh oh!

Uh oh!

catriona-m left a comment

Uh oh!

Uh oh!

catriona-m left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bubbletroubles commented Feb 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bubbletroubles commented Feb 1, 2025 •

edited

Loading