Skip to content

azurerm_container_app - fix validation for container app name and container names#28528

Merged
stephybun merged 2 commits intohashicorp:mainfrom
dylan8902:bugfix/24591-containerapp-validation
Jan 28, 2025
Merged

azurerm_container_app - fix validation for container app name and container names#28528
stephybun merged 2 commits intohashicorp:mainfrom
dylan8902:bugfix/24591-containerapp-validation

Conversation

@dylan8902
Copy link
Contributor

@dylan8902 dylan8902 commented Jan 16, 2025 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Fixes validation regex for container app names and container names.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #24591

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@dylan8902 dylan8902 requested a review from a team as a code owner January 16, 2025 15:33
@dylan8902 dylan8902 changed the title azurerm_container_app - fix validation for container app name and container names azurerm_container_app - fix validation for container app name and container names Jan 16, 2025
stephybun
stephybun previously approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dylan8902 LGTM 👍

@stephybun stephybun dismissed their stale review January 27, 2025 13:27

My bad, formatting needs to be fixed first

@dylan8902
Copy link
Contributor Author

dylan8902 commented Jan 28, 2025

@stephybun - no sorry my bad. Ran the linter now

stephybun
stephybun approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dylan8902 LGTM 🎉

@stephybun stephybun merged commit 9ae1924 into hashicorp:main Jan 28, 2025
29 checks passed
@github-actions github-actions bot added this to the v4.17.0 milestone Jan 28, 2025
stephybun added a commit that referenced this pull request Jan 28, 2025
@stephybun
Update #28528
cb0c766
jackofallops added a commit that referenced this pull request Jan 31, 2025
@stephybun @catriona-m
@jackofallops @sreallymatt @mbfrahry
CHANGELOG.md for 4.17.0 (#28561)
3c5cace 
* Update for #27950

* Update for #27824

* Update for #28592 #28583 #28599 #28590 #28453

* Update #28528

* Update for #27853

* Update CHANGELOG.md #28221

* Update for #27760

* Update CHANGELOG.md #28480

* Update CHANGELOG.md typo

* Update CHANGELOG.md #28372

* Update CHANGELOG.md for #26047

also alphabetised ENHANCEMENTS

* Update for #28146

* Update CHANGELOG.md #28013

* Update CHANGELOG.md for #28492

* Update CHANGELOG.md for #28648

* Update CHANGELOG.md for #28549

* Update for #28469 #28620

* prep for release

* i touched it last

---------

Co-authored-by: catriona-m <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
hqhqhqhqhqhqhqhqhqhqhq pushed a commit to hqhqhqhqhqhqhqhqhqhqhq/terraform-provider-azurerm that referenced this pull request Feb 26, 2025
@stephybun @catriona-m
@jackofallops @sreallymatt @mbfrahry @hqhqhqhqhqhqhqhqhqhqhq
CHANGELOG.md for 4.17.0 (hashicorp#28561)
64f1321 
* Update for hashicorp#27950

* Update for hashicorp#27824

* Update for hashicorp#28592 hashicorp#28583 hashicorp#28599 hashicorp#28590 hashicorp#28453

* Update hashicorp#28528

* Update for hashicorp#27853

* Update CHANGELOG.md hashicorp#28221

* Update for hashicorp#27760

* Update CHANGELOG.md hashicorp#28480

* Update CHANGELOG.md typo

* Update CHANGELOG.md hashicorp#28372

* Update CHANGELOG.md for hashicorp#26047

also alphabetised ENHANCEMENTS

* Update for hashicorp#28146

* Update CHANGELOG.md hashicorp#28013

* Update CHANGELOG.md for hashicorp#28492

* Update CHANGELOG.md for hashicorp#28648

* Update CHANGELOG.md for hashicorp#28549

* Update for hashicorp#28469 hashicorp#28620

* prep for release

* i touched it last

---------

Co-authored-by: catriona-m <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stephybun stephybun stephybun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug service/container-apps size/M

Projects

None yet

Milestone

v4.17.0

Development

Successfully merging this pull request may close these issues.

ContainerApp name validation 60-characters limit is bigger than the Resource 32-characters limit

2 participants

@dylan8902 @stephybun