Skip to content

azurerm_ai_foundry_project: add support for primary_user_assigned_identity#29197

Merged
catriona-m merged 5 commits intohashicorp:mainfrom
wuxu92:aifoundry/user-identity
May 6, 2025
Merged

azurerm_ai_foundry_project: add support for primary_user_assigned_identity#29197
catriona-m merged 5 commits intohashicorp:mainfrom
wuxu92:aifoundry/user-identity

Conversation

@wuxu92
Copy link
Collaborator

@wuxu92 wuxu92 commented Mar 27, 2025 •
edited
Loading

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The user identity should specifid by separate field as PrimaryUserAssignedIdentity. API Spec reference: https://github.com/Azure/azure-rest-api-specs/blob/c488b4a741cb78f93514d7a9d3332d08ea7b32e1/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2024-04-01/workspaceRP.json#L1812

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • [x I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #29074

@wuxu92 wuxu92 marked this pull request as ready for review March 31, 2025 00:40
@wuxu92 wuxu92 requested a review from a team as a code owner March 31, 2025 00:40
@wuxu92 wuxu92 force-pushed the aifoundry/user-identity branch from 0327cd3 to 1473ead Compare March 31, 2025 00:48
catriona-m
catriona-m requested changes May 2, 2025
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 - I left a couple of comments inline but once those are addressed we can take another look at this. Thanks!

@katiepatterson0
Copy link

katiepatterson0 commented May 2, 2025

Hi @wuxu92 ! We have reviewed this on the HashiCorp side and provided some comments to be addressed. Please review and then merge once you are finished if you're able. Thanks in advance!

catriona-m
catriona-m approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @wuxu92 - this LGTM!

@catriona-m catriona-m merged commit ea6c35d into hashicorp:main May 6, 2025
35 checks passed
@github-actions github-actions bot added this to the v4.28.0 milestone May 6, 2025
catriona-m added a commit that referenced this pull request May 6, 2025
@catriona-m
Update CHANGELOG.md #29197
4fb3ce9
teowa pushed a commit to teowa/terraform-provider-azurerm that referenced this pull request May 8, 2025
@wuxu92 @teowa
azurerm_ai_foundry_project: add support for `primary_user_assigned_…
8eb9172 
…identity` (hashicorp#29197)

* add primary_user_assigned_identity to ai foundry project

* primary user identity should be in identity block

* update acc test format

* code/doc clean

* terrafmt
jackofallops added a commit that referenced this pull request May 9, 2025
@rcskosir @catriona-m
@WodansSon @sreallymatt @mbfrahry @jackofallops
CHANGELOG.md for v4.28.0 (#29421)
4b6b37c 
* changelog for 4.28 release

* Update CHANGELOG.md #29410

* Update CHANGELOG.md #29397

* Update CHANGELOG.md #27454

* Update CHANGELOG.md #28919

* Update CHANGELOG.md #29443

* Update CHANGELOG.md #29443

* Update CHANGELOG.md #29456

* Update CHANGELOG.md for #29424

* Update CHANGELOG.md for #29150

* Update CHANGELOG.md #29435

* Update CHANGELOG.md #29431

* Update CHANGELOG.md #29396

* Update CHANGELOG.md #29197

* Update CHANGELOG.md for #28705

* Update CHANGELOG.md #28954

* Update CHANGELOG.md for #29363

* prep for release

---------

Co-authored-by: catriona-m <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees

@catriona-m catriona-m

Labels

bug documentation service/machine-learning size/L

Projects

None yet

Milestone

v4.28.0

Development

Successfully merging this pull request may close these issues.

azurerm_ai_foundry_project 400 internal error when using 'UserAssigned' identity type

4 participants

@wuxu92 @katiepatterson0 @catriona-m @katbyte