container apps - support for additional settings in container apps probes by SpartakusMd · Pull Request #27551 · hashicorp/terraform-provider-azurerm

SpartakusMd · 2024-10-02T11:17:01Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

The available settings for the configuration of the liveness, readiness and startup probes in Azure Container Apps are lacking a few details.

FYI, There are some defaults for existing probe settings which are different between Azure and Terraform, I left them intact.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_container_app - added missing settings in liveness_probe, startup_probe and readiness_probe [Support for additional settings in liveness_probe, startup_probe and readiness_probe #25457]

This is a (please select all that apply):

Enhancement

Related Issue(s)

Fixes #25457, fixes #24845

internal/services/containerapps/helpers/container_apps.go

… startup_probe and readiness_probe hashicorp#25457

stephybun · 2024-10-24T09:23:35Z

internal/services/containerapps/helpers/container_apps.go

+					Type:         pluginsdk.TypeInt,
+					Optional:     true,
+					Default:      1,
+					ValidateFunc: validation.IntBetween(1, 1),


Can this be set to anything other than 1?

stephybun · 2024-10-24T09:24:51Z

internal/services/containerapps/helpers/container_apps.go

+					Type:         pluginsdk.TypeInt,
+					Optional:     true,
+					Default:      1,
+					ValidateFunc: validation.IntBetween(1, 1),


Likewise here, is there a point in exposing this if it's default is 1 and can only be set to 1 anyway?

No, it should be exactly 1. I added it as it's present in UI an in ContainerAppReadinessProbeSchema. Should I remove it?

Can we please remove this then (from the Computed schemas as well)

Removed where I added it. But kept it in ContainerAppReadinessProbeSchema to not create a breaking change

…ppStartupProbe

stephybun

Thanks @SpartakusMd, I've kicked off the tests. Would you mind updating the documentation with these changes as well?

SpartakusMd · 2024-10-24T12:21:48Z

@stephybun I have added the docs. Is there anything else?

stephybun

Tests look good, thanks @SpartakusMd LGTM 👍

SpartakusMd · 2024-10-24T12:36:38Z

Thank you @stephybun for the time spent!

Dmitriyx · 2024-10-28T14:20:23Z

internal/services/containerapps/helpers/container_apps.go

+		InitialDelaySeconds: pointer.To(input.InitialDelay),
+		PeriodSeconds:       pointer.To(input.Interval),
+		TimeoutSeconds:      pointer.To(input.Timeout),
+		FailureThreshold:    pointer.To(input.FailureThreshold),


how come there is no success threshold property here?

I have a container app that is failing because I can not set a success_count_threshold to it, it will assign it an empty value.
Since I have a container app that is a public container that accepts ingress, Azure does a health check of the service using startup probe.
Since I can not configure it via terraform, my container always fails until I manually configure it on the UI to have a success threshold count to be 1, which then works fine

according to the issue you are responding too: #25457
startup_probe should also have a success threshold.

It was added initialy, but removed later in the same PR due to review in c8002c0

It was removed due to the fact that only a single value is accepted and that is 1. You cannot set the value to anything else. I also use this code for our infra and it's working as expected.

The question would be how it worked until now as the option wasn't present there? If it's really needed, I guess you could create a PR with the changes from that commit to add the success threshold property and see if it's merged.

thank you for a quick response, just tested it again and I do not get the same result - somehow success count threshold is not defaulted to 1. Any ideas on what can be done?

You could create a new PR with changes from c8002c0 and put the screenshot as an explanation. Are you sure it fails due to the value being empty?

Yes I am sure - because once I edit the container config on the UI, once I add a success threshold, then the container lives, otherwise it just dies and keeps restarting.

I attempted to make a PR however I get denied
remote: Permission to hashicorp/terraform-provider-azurerm.git denied to Dmitriyx

I will check what the rules are for making a PR

You need to fork the repo and make changes in the forked repository. Afterwards you can create a PR in Github.

github-actions · 2024-11-28T02:17:22Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added service/container-apps size/M labels Oct 2, 2024

RomanKreisel mentioned this pull request Oct 9, 2024

azurerm_container_app - Support for additional settings in liveness_probe, startup_probe and readiness_probe #26573

Closed

10 tasks

rcskosir added the enhancement label Oct 14, 2024

stephybun suggested changes Oct 24, 2024

View reviewed changes

internal/services/containerapps/helpers/container_apps.go Show resolved Hide resolved

github-actions bot added the waiting-response label Oct 24, 2024

SpartakusMd added 3 commits October 24, 2024 12:08

Support for additional settings in container apps for liveness_probe,…

280872a

… startup_probe and readiness_probe hashicorp#25457

add flatten / expand logic

174ca02

fix field name

9c3c7bc

stephybun reviewed Oct 24, 2024

View reviewed changes

Remove SuccessThreshold from ContainerAppLivenessProbe and ContainerA…

c8002c0

…ppStartupProbe

SpartakusMd force-pushed the feature/Support-for-additional-settings-in-container-apps-probes branch from ce30625 to c8002c0 Compare October 24, 2024 10:14

SpartakusMd requested review from a team and katbyte as code owners October 24, 2024 10:14

github-actions bot removed the waiting-response label Oct 24, 2024

SpartakusMd requested a review from stephybun October 24, 2024 10:28

stephybun reviewed Oct 24, 2024

View reviewed changes

github-actions bot added the waiting-response label Oct 24, 2024

add documentation

2114fd6

github-actions bot added documentation and removed waiting-response labels Oct 24, 2024

stephybun approved these changes Oct 24, 2024

View reviewed changes

stephybun merged commit b0ddd5f into hashicorp:main Oct 24, 2024

github-actions bot added this to the v4.7.0 milestone Oct 24, 2024

stephybun added a commit that referenced this pull request Oct 24, 2024

Update for #27551

d1cc457

Dmitriyx reviewed Oct 28, 2024

View reviewed changes

github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024

Conversation

SpartakusMd commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephybun Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

SpartakusMd commented Oct 24, 2024

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

SpartakusMd commented Oct 24, 2024

Uh oh!

Dmitriyx Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dmitriyx Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dmitriyx Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dmitriyx Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dmitriyx Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SpartakusMd commented Oct 2, 2024 •

edited

Loading

stephybun Oct 24, 2024 •

edited

Loading

Dmitriyx Oct 28, 2024 •

edited

Loading

Dmitriyx Oct 28, 2024 •

edited

Loading

Dmitriyx Oct 28, 2024 •

edited

Loading

Dmitriyx Oct 28, 2024 •

edited

Loading

Dmitriyx Oct 28, 2024 •

edited

Loading