Skip to content

azurerm_firewall and azurerm_firewall_policy implement list#31734

Merged
mstroob merged 10 commits intomainfrom
mstroob/firewall-list-and-identity
Feb 17, 2026
Merged

azurerm_firewall and azurerm_firewall_policy implement list#31734
mstroob merged 10 commits intomainfrom
mstroob/firewall-list-and-identity

Conversation

@mstroob
Copy link
Contributor

@mstroob mstroob commented Feb 12, 2026

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

adds list to both firewall and firewall policy resource

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@mstroob mstroob requested review from a team, WodansSon and magodo as code owners February 12, 2026 18:26
@mstroob
Copy link
Contributor Author

mstroob commented Feb 15, 2026

Team City Test Results:

PR Number: 31734
Build Number: 612062

All Tests
Status Test Name Duration
✅ PASS TestAccFirewallDataSource_withManagementIp 624.09s
✅ PASS TestAccFirewallApplicationRuleCollection_noSource 849.53s
✅ PASS TestAccFirewallDataSource_withFirewallPolicy 859.92s
✅ PASS TestAccFirewallDataSource_basic 862.41s
✅ PASS TestAccFirewallDataSource_enableDNS 1026.39s
✅ PASS TestAccFirewallApplicationRuleCollection_multipleProtocols 1284.37s
✅ PASS TestAccFirewallApplicationRuleCollection_ipGroups 1299.56s
✅ PASS TestAccFirewallApplicationRuleCollection_requiresImport 1355.63s
✅ PASS TestAccFirewallApplicationRuleCollection_disappears 1440.22s
✅ PASS TestAccFirewallApplicationRuleCollection_fqdnTags 1527.44s
✅ PASS TestAccFirewallApplicationRuleCollection_updateFirewallTags 1661.53s
✅ PASS TestAccFirewallApplicationRuleCollection_updatedName 1660.91s
✅ PASS TestAccFirewallNatRuleCollection_basic 1814.18s
✅ PASS TestAccFirewallNatRuleCollection_requiresImport 1937.47s
✅ PASS TestAccFirewallApplicationRuleCollection_basic 1969.98s
✅ PASS TestAccFirewallNatRuleCollection_disappears 1235.27s
✅ PASS TestAccFirewallNatRuleCollection_noSource 749.62s
✅ PASS TestAccFirewallApplicationRuleCollection_updateProtocols 2123.99s
✅ PASS TestAccFirewallApplicationRuleCollection_multipleRuleCollections 2395.37s
✅ PASS TestAccFirewallApplicationRuleCollection_multipleRules 2652.60s
✅ PASS TestAccFirewallNatRuleCollection_updatedName 2222.08s
✅ PASS TestAccFirewallNatRuleCollection_multipleRules 1916.80s
✅ PASS TestAccFirewallNetworkRuleCollection_requiresImport 1427.67s
✅ PASS TestAccFirewallNatRuleCollection_updateFirewallTags 1739.81s
✅ PASS TestAccFirewallDataSource_inVirtualhub 3054.62s
✅ PASS TestAccFirewallPolicy_resourceIdentity 110.60s
✅ PASS TestAccFirewallPolicyDataSource_basic 129.26s
✅ PASS TestAccFirewallNatRuleCollection_update 2235.54s
✅ PASS TestAccfirewallPolicy_listBySuscriptionAndRG 89.81s
✅ PASS TestAccFirewallPolicy_basic 122.59s
✅ PASS TestAccFirewallNetworkRuleCollection_updatedName 1519.09s
✅ PASS TestAccFirewallPolicy_basicPremium 117.50s
✅ PASS TestAccFirewallPolicy_complete 215.79s
✅ PASS TestAccFirewallPolicy_requiresImport 110.43s
✅ PASS TestAccFirewallNatRuleCollection_ipGroup 2023.80s
✅ PASS TestAccFirewallPolicy_inherit 141.26s
✅ PASS TestAccFirewallNetworkRuleCollection_basic 1921.10s
✅ PASS TestAccFirewallPolicy_update 281.01s
✅ PASS TestAccFirewallApplicationRuleCollection_update 3405.89s
✅ PASS TestAccFirewallPolicyRuleCollectionGroup_basic 142.97s
✅ PASS TestAccFirewallPolicyRuleCollectionGroup_completePremium 149.19s
✅ PASS TestAccFirewallPolicyRuleCollectionGroup_complete 152.15s
✅ PASS TestAccFirewallPolicyRuleCollectionGroup_requiresImport 158.33s
✅ PASS TestAccFirewallPolicyRuleCollectionGroup_update 264.13s
✅ PASS TestAccFirewallPolicy_insights 342.80s
✅ PASS TestAccFirewallPolicyRuleCollectionGroup_updatePremium 265.62s
✅ PASS TestAccFirewallNetworkRuleCollection_noDestination 829.98s
✅ PASS TestAccFirewallNetworkRuleCollection_fqdns 1310.32s
✅ PASS TestAccFirewallNetworkRuleCollection_noSource 1121.36s
✅ PASS TestAccFirewall_withManagementIpSameName 118.05s
✅ PASS TestAccFirewallNetworkRuleCollection_updateFirewallTags 1729.75s
✅ PASS TestAccFirewallNetworkRuleCollection_disappears 1999.77s
✅ PASS TestAccFirewallNetworkRuleCollection_serviceTag 1839.91s
✅ PASS TestAccFirewallNetworkRuleCollection_multipleRuleCollections 2307.57s
✅ PASS TestAccFirewallNetworkRuleCollection_ipGroup 1847.86s
✅ PASS TestAccFirewallPolicy_completePremium 956.15s
✅ PASS TestAccFirewall_complete 495.22s
✅ PASS TestAccFirewallPolicy_updatePremium 1008.93s
✅ PASS TestAccFirewall_resourceIdentity 773.86s
✅ PASS TestAccFirewall_listBySubscriptionAndRG 755.28s
✅ PASS TestAccFirewall_requiresImport 517.41s
✅ PASS TestAccFirewall_basic 857.38s
✅ PASS TestAccFirewallNatRuleCollection_multipleRuleCollections 3563.19s
✅ PASS TestAccFirewall_disappears 483.94s
✅ PASS TestAccFirewall_withZones 634.49s
✅ PASS TestAccFirewall_withManagementIpNoMainPublicIp 1050.91s
✅ PASS TestAccFirewall_withMultiplePublicIPs 1023.66s
✅ PASS TestAccFirewallNetworkRuleCollection_multipleRules 2802.64s
✅ PASS TestAccFirewall_withManagementIp 1169.38s
✅ PASS TestAccFirewall_withTags 1137.39s
✅ PASS TestAccFirewall_withoutZone 1258.94s
✅ PASS TestAccFirewallNetworkRuleCollection_update 3442.58s
✅ PASS TestAccFirewall_withFirewallPolicy 1707.29s
✅ PASS TestAccFirewall_privateRanges 1874.00s
✅ PASS TestAccFirewall_enableDNS 2374.07s
✅ PASS TestAccFirewall_inVirtualHub 2996.78s
✅ PASS TestAccFirewall_skuTierUpdate 3277.00s

Total Passed: 77
Total Failed: 0
Total Tests: 77

sreallymatt
sreallymatt requested changes Feb 17, 2026
View reviewed changes
sreallymatt
sreallymatt approved these changes Feb 17, 2026
View reviewed changes
Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@mstroob mstroob merged commit 71414a8 into main Feb 17, 2026
48 checks passed
@mstroob mstroob deleted the mstroob/firewall-list-and-identity branch February 17, 2026 20:26
@github-actions github-actions bot added this to the v4.61.0 milestone Feb 17, 2026
anurag-hashicorp pushed a commit to anurag-hashicorp/terraform-provider-azurerm that referenced this pull request Feb 19, 2026
@mstroob @anurag-hashicorp
azurerm_firewall and azurerm_firewall_policy implement list (hash…
5c8bb8b 
…icorp#31734)

* `azurerm_firewall` and `azurerm_firewall_policy` implement list (hashicorp#31734)
@github-actions github-actions bot mentioned this pull request Feb 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sreallymatt sreallymatt sreallymatt approved these changes

@WodansSon WodansSon Awaiting requested review from WodansSon WodansSon is a code owner

@magodo magodo Awaiting requested review from magodo magodo is a code owner

Assignees

No one assigned

Labels

documentation new-list-resource service/firewall size/XL

Projects

None yet

Milestone

v4.61.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mstroob @sreallymatt @katbyte @rcskosir