support for the `virtual_network_integration_enabled` and `subnet_id` properties by ms-henglu · Pull Request #30559 · hashicorp/terraform-provider-azurerm

ms-henglu · 2025-09-05T01:07:52Z

This PR adds back features that are reverted by #30551.

It's based on #30516

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…- support for the `vnet_integration_enabled` and `subnet_id` properties

ms-henglu · 2025-09-08T01:37:20Z

Tests:

sreallymatt

Thanks @ms-henglu, I've left a question regarding the implementation of these new properties if you wouldn't mind confirming

sreallymatt · 2025-09-08T17:30:24Z

internal/services/containers/kubernetes_cluster_resource.go

 								ValidateFunc: validate.CIDR,
 							},
 						},
+						"vnet_integration_enabled": {


Following the naming guide I think we should avoid abbreviating virtual_network to vnet

Suggested change

"vnet_integration_enabled": {

"virtual_network_integration_enabled": {

internal/services/containers/kubernetes_cluster_resource.go

website/docs/r/kubernetes_cluster.html.markdown

Co-authored-by: sreallymatt <[email protected]>

ms-henglu · 2025-09-10T05:11:18Z

Hi @sreallymatt , thanks for the code review! I've applied the suggestion and add a test case for the managed vnet.

=== RUN   TestAccKubernetesCluster_apiServerVnetIntegrationManagedVnet
=== PAUSE TestAccKubernetesCluster_apiServerVnetIntegrationManagedVnet
=== CONT  TestAccKubernetesCluster_apiServerVnetIntegrationManagedVnet
--- PASS: TestAccKubernetesCluster_apiServerVnetIntegrationManagedVnet (636.82s)
PASS

sreallymatt

Thanks for making those changes @ms-henglu, LGTM ✅

c3-davidtran · 2025-09-29T12:35:17Z

@sreallymatt Provider v4 was meant to remove those flags to avoid using preview features.
While your change does allow us to configure properties vnet_integration_enabled and subnet_id, the azure Go SDK version still references preview API.

When using the 4.46.0 provider version, here is what I get :

│ Kubernetes Cluster Name: "cluster-aks"): performing CreateOrUpdate: unexpected status 400 (400 Bad Request) with response: {
│   "code": "BadRequest",
│   "details": null,
│   "message": "Feature Microsoft.ContainerService/EnableAPIServerVnetIntegrationPreview is not enabled. Please see https://aka.ms/aks/previews for how to enable features.",
│   "subcode": ""
│  }

Could a fix be provided to fix this behavior?

github-actions · 2025-10-30T02:21:53Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ms-henglu added 3 commits September 1, 2025 11:22

azurerm_kubernetes_cluster, azurerm_kubernetes_cluster_node_pool …

cd9ffdd

…- support for the `vnet_integration_enabled` and `subnet_id` properties

resolve review comments

23a8f33

fix drift

833e9b7

github-actions bot added documentation size/M labels Sep 5, 2025

ms-henglu marked this pull request as ready for review September 8, 2025 01:37

ms-henglu requested review from a team, WodansSon and magodo as code owners September 8, 2025 01:37

mybayern1974 assigned magodo Sep 8, 2025

sreallymatt reviewed Sep 8, 2025

View reviewed changes

github-actions bot added the waiting-response label Sep 8, 2025

magodo removed their assignment Sep 8, 2025

rename to virtual_network_integration_enabled

8626141

github-actions bot removed the waiting-response label Sep 9, 2025

sreallymatt requested changes Sep 9, 2025

View reviewed changes

internal/services/containers/kubernetes_cluster_resource.go Show resolved Hide resolved

internal/services/containers/kubernetes_cluster_resource.go Outdated Show resolved Hide resolved

website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved

github-actions bot assigned sreallymatt Sep 9, 2025

github-actions bot added the waiting-response label Sep 9, 2025

Apply suggestions from code review

e183eb6

Co-authored-by: sreallymatt <[email protected]>

github-actions bot removed the waiting-response label Sep 10, 2025

add TestAccKubernetesCluster_apiServerVnetIntegrationManagedVnet

5eb1db1

github-actions bot added size/L and removed size/M labels Sep 10, 2025

github-actions bot added the enhancement label Sep 10, 2025

ms-henglu requested a review from sreallymatt September 22, 2025 06:17

sreallymatt approved these changes Sep 24, 2025

View reviewed changes

sreallymatt changed the title ~~support for the vnet_integration_enabled and subnet_id properties~~ support for the virtual_network_integration_enabled and subnet_id properties Sep 24, 2025

sreallymatt merged commit 3c540a2 into hashicorp:main Sep 24, 2025
35 checks passed

github-actions bot added this to the v4.46.0 milestone Sep 24, 2025

sreallymatt added a commit that referenced this pull request Sep 24, 2025

Update CHANGELOG.md #30559

1761fdc

EppO mentioned this pull request Sep 24, 2025

azurerm_kubernetes_cluster - add api_server_vnet_integration_enabled and api_server_subnet_id #30496

Closed

14 tasks

mbfrahry pushed a commit that referenced this pull request Sep 25, 2025

Update CHANGELOG.md #30559

a024322

amoosbr mentioned this pull request Sep 26, 2025

Support for AKS API Server VNet Integration Azure/terraform-azurerm-aks#393

Closed

1 task

c3-davidtran mentioned this pull request Sep 29, 2025

Terraform azurerm_kubernetes_cluster - v4.46.0 - EnableAPIServerVnetIntegrationPreview is not enabled #30731

Closed

1 task

stijndehaes mentioned this pull request Oct 1, 2025

v4 removed private vnet integration for API server in azurerm_kubernetes_cluster #27640

Closed

1 task

nlighten mentioned this pull request Oct 1, 2025

[AVM Module Issue]: Private AKS cluster - Enable API Server VNET Integration Azure/terraform-azurerm-avm-res-containerservice-managedcluster#99

Closed

1 task

github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support for the `virtual_network_integration_enabled` and `subnet_id` properties#30559

support for the `virtual_network_integration_enabled` and `subnet_id` properties#30559
sreallymatt merged 6 commits intohashicorp:mainfrom
ms-henglu:branch-250820-aks-vnet-integration

ms-henglu commented Sep 5, 2025 •

edited by rcskosir

Loading

Uh oh!

ms-henglu commented Sep 8, 2025

Uh oh!

sreallymatt left a comment

Uh oh!

sreallymatt Sep 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ms-henglu commented Sep 10, 2025

Uh oh!

sreallymatt left a comment

Uh oh!

Uh oh!

c3-davidtran commented Sep 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	"vnet_integration_enabled": {
	"virtual_network_integration_enabled": {

Conversation

ms-henglu commented Sep 5, 2025 • edited by rcskosir Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Rollback Plan

Changes to Security Controls

Uh oh!

ms-henglu commented Sep 8, 2025

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

sreallymatt Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ms-henglu commented Sep 10, 2025

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

c3-davidtran commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ms-henglu commented Sep 5, 2025 •

edited by rcskosir

Loading

c3-davidtran commented Sep 29, 2025 •

edited

Loading