Skip to content

azurerm_databricks_workspace - Adding custom_parameters attributes to datasource#30214

Merged
magodo merged 1 commit intohashicorp:mainfrom
promisinganuj:promisinganuj/30068-changes
Jul 23, 2025
Merged

azurerm_databricks_workspace - Adding custom_parameters attributes to datasource#30214
magodo merged 1 commit intohashicorp:mainfrom
promisinganuj:promisinganuj/30068-changes

Conversation

@promisinganuj
Copy link
Collaborator

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Adding custom_parameters attributes list to azurerm_databricks_workspace datasource:

....
  "custom_parameters": [
    {
      "machine_learning_workspace_id": "<machine_learning_workspace_id>",
      "nat_gateway_name": "<nat_gateway_name>",
      "no_public_ip": <true/false>,
      "private_subnet_name": "<private_subnet_name>",
      "public_ip_name": "<public_ip_name>",
      "public_subnet_name": "<public_subnet_name>",
      "storage_account_name": "<default_storage_account_name>",
      "storage_account_sku_name": "<default_storage_account_sku_name>",
      "virtual_network_id": "<virtual_network_resource_id>",
      "vnet_address_prefix": "<virtual_network_address_prefix>"
    }
  ],
...

Please note that the following resource attributes are not included in the datasource as these are no available in the REST API:

  • private_subnet_network_security_group_association_id
  • public_subnet_network_security_group_association_id

Also created a simple acceptance test reusing the existing resource test code.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_databricks_workspace - Adding custom_parameters attributes to datasource

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #30068

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@promisinganuj promisinganuj requested review from a team, WodansSon and magodo as code owners July 23, 2025 03:35
@promisinganuj promisinganuj changed the title azurerm_databricks_workspace - Adding custom_parameters attributes to datasource azurerm_databricks_workspace - Adding custom_parameters attributes to datasource Jul 23, 2025
@promisinganuj
Copy link
Collaborator Author

Acceptance Test result:
image

@magodo
Copy link
Collaborator

magodo commented Jul 23, 2025

Thanks @promisinganuj! It LGTM!

@magodo magodo merged commit 7f17e06 into hashicorp:main Jul 23, 2025
34 checks passed
@github-actions github-actions bot added this to the v4.38.0 milestone Jul 23, 2025
magodo added a commit that referenced this pull request Jul 23, 2025
@promisinganuj promisinganuj deleted the promisinganuj/30068-changes branch July 23, 2025 04:17
jackofallops pushed a commit that referenced this pull request Jul 30, 2025
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage_account_name in azurerm_databricks_workspace data source

2 participants