Skip to content

New Resource: azurerm_api_management_workspace#30033

Merged
catriona-m merged 3 commits intohashicorp:mainfrom
sinbai:apim/support_new_resource_workspace
Jul 9, 2025
Merged

New Resource: azurerm_api_management_workspace#30033
catriona-m merged 3 commits intohashicorp:mainfrom
sinbai:apim/support_new_resource_workspace

Conversation

@sinbai
Copy link
Contributor

@sinbai sinbai commented Jun 27, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/6a16ff795e378b86c7d9828d82e359555157a2f1/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2024-05-01/apimworkspaces.json#L196

Document: https://learn.microsoft.com/en-us/azure/api-management/workspaces-overview

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Test Results：
PASS: TestAccApiManagementWorkspace_basic (1637.10s)
PASS: TestAccApiManagementWorkspace_requiresImport
PASS: TestAccApiManagementWorkspace_complete (1752.77s)
PASS: TestAccApiManagementWorkspace_update (2750.08s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #21109

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

ms-zhenhua
ms-zhenhua suggested changes Jul 4, 2025
View reviewed changes
Copy link
Collaborator

@ms-zhenhua ms-zhenhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sinbai ,

Thanks for this PR - I've taken a look through and left only one minor comment. If we can fix those up, this should be good to go 👍

website/docs/r/apimanagement_workspace.html.markdown Outdated
```hcl
resource "azurerm_resource_group" "example" {
name = "example-resources"
location = "East US"
Copy link
Collaborator

@ms-zhenhua ms-zhenhua Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep consistent with existing resources, the location should be "West Europe".

Copy link
Contributor Author

@sinbai sinbai Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@sinbai sinbai force-pushed the apim/support_new_resource_workspace branch from ce2f01f to a1f0a0e Compare July 4, 2025 08:46
@sinbai
Copy link
Contributor Author

sinbai commented Jul 4, 2025

Hi @sinbai ,

Thanks for this PR - I've taken a look through and left only one minor comment. If we can fix those up, this should be good to go 👍

Hi @ms-zhenhua, thanks for your feedback. I have fixed the comment. Could you please take another look?

ms-zhenhua
ms-zhenhua previously approved these changes Jul 4, 2025
View reviewed changes
@sinbai sinbai marked this pull request as ready for review July 4, 2025 09:14
@sinbai sinbai requested a review from a team as a code owner July 4, 2025 09:14
@catriona-m catriona-m self-assigned this Jul 8, 2025
catriona-m
catriona-m requested changes Jul 8, 2025
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @sinbai thanks for submitting this, this is off to a good start, I just left one comment inline for you to consider and then I can take another look. Thanks!

@sinbai
Copy link
Contributor Author

sinbai commented Jul 9, 2025

HI @sinbai thanks for submitting this, this is off to a good start, I just left one comment inline for you to consider and then I can take another look. Thanks!

Hi @catriona-m I have replied the comment and updated the documentation accordingly. Would you mind reviewing it again?

catriona-m
catriona-m approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai LGTM!

@catriona-m catriona-m merged commit 05e43ff into hashicorp:main Jul 9, 2025
33 checks passed
@github-actions github-actions bot added this to the v4.36.0 milestone Jul 9, 2025
@sreallymatt sreallymatt mentioned this pull request Jul 18, 2025
Closed
14 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@catriona-m catriona-m catriona-m approved these changes

+1 more reviewer

@ms-zhenhua ms-zhenhua ms-zhenhua left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@catriona-m catriona-m

Labels

dependencies documentation service/api-management service/communication service/cosmosdb service/log-analytics service/machine-learning service/network service/purview size/XL

Projects

None yet

Milestone

v4.36.0

Development

Successfully merging this pull request may close these issues.

Support for API Management Workspaces

4 participants

@sinbai @ms-zhenhua @catriona-m @katbyte