Skip to content

azurerm_virtual_hub - support for new property branch_to_branch_traffic_enabled#29453

Merged
sreallymatt merged 2 commits intohashicorp:mainfrom
neil-yechenwei:vhuballowBranchToBranchTraffic
Jul 4, 2025
Merged

azurerm_virtual_hub - support for new property branch_to_branch_traffic_enabled#29453
sreallymatt merged 2 commits intohashicorp:mainfrom
neil-yechenwei:vhuballowBranchToBranchTraffic

Conversation

@neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Apr 30, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support new property allow_branch_to_branch_traffic in azurerm_virtual_hub.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_virtual_hub - support for new property allow_branch_to_branch_traffic

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #18802

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@neil-yechenwei neil-yechenwei changed the title azurerm_virtual_hub - support for new property allow_branch_to_branch_traffic azurerm_virtual_hub - support for new property branch_to_branch_traffic_enabled Jul 4, 2025
@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jul 4, 2025

@sreallymatt , thanks for the comment. I updated PR. Below is the latest test result. Please take another look.

--- PASS: TestAccVirtualHub_basic (1760.44s)
--- PASS: TestAccVirtualHub_auto_scale_min_capacity (1807.67s)
--- PASS: TestAccVirtualHub_tags (1826.20s)
--- PASS: TestAccDataSourceAzureRMVirtualHub_basic (1914.61s)
--- PASS: TestAccVirtualHub_routes (2229.10s)
--- PASS: TestAccVirtualHub_requiresImport (1772.47s)
--- PASS: TestAccVirtualHub_hubRoutingPreference (1916.63s)

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for renaming the property, @neil-yechenwei, LGTM ✅

@sreallymatt sreallymatt merged commit e1b84ba into hashicorp:main Jul 4, 2025
35 checks passed
@github-actions github-actions bot added this to the v4.36.0 milestone Jul 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Virtual Hubs additional properties (virtualRouterAsn / hubRoutingPreference / allowBranchToBranchTraffic)

4 participants