`azurerm_cognitive_deployment` - change validation function on `model.format` by liuwuliuyun · Pull Request #29143 · hashicorp/terraform-provider-azurerm

liuwuliuyun · 2025-03-21T06:19:57Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

azurerm_cognitive_deployment - Change validation function on model.format

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_cognitive_deployment - change validation function on model.format [azurerm_cognitive_deployment - change validation function on model.format #29143]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #29117

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

catriona-m

Thanks @liuwuliuyun. Is there a list of valid format values we could use for the validation?

liuwuliuyun · 2025-03-26T06:37:59Z

Thanks @liuwuliuyun. Is there a list of valid format values we could use for the validation?

Hi, I reviewed the docs and swagger repo but couldn't find a list of supported formats. Therefore, I have no choice but to use a non-empty string validation function here.

katbyte

Instead of removing all validation could we just add the new cohere value instead?

liuwuliuyun · 2025-04-22T05:19:01Z

Instead of removing all validation could we just add the new cohere value instead?

I have changed this PR to add Cohere into supported list.

catriona-m

Thanks @liuwuliuyun LGTM!

comment addressed

* Update CHANGELOG.md #29285, #29294 * Update CHANGELOG.md for #29307 * Update CHANGELOG.md #29283 * Update CHANGELOG.md #29271 * Update CHANGELOG.md #29298 * Update CHANGELOG.md #29278 * Update CHANGELOG.md #29341 * Update CHANGELOG.md #29328 * Update CHANGELOG.md #29292 * Update CHANGELOG.md #29361 * Update CHANGELOG.md #29296 * Update CHANGELOG.md #28239 * Update CHANGELOG.md #28974 * Update CHANGELOG.md #29254 * Update CHANGELOG.md #29333 * Update CHANGELOG.md #29314 * Update CHANGELOG.md #28929 * Update CHANGELOG.md for #29382 * Update for #28676 * Update CHANGELOG.md for #28740 * Update CHANGELOG.md for #28559 * Update CHANGELOG.md #29143 * Update CHANGELOG.md #29329 * Update CHANGELOG.md #29380 * Update CHANGELOG.md #29309 * Update CHANGELOG.md #29317 * prep for release --------- Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: kt <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: jackofallops <[email protected]>

….format` (hashicorp#29143) * Support other format in azurerm_cognitive_deployments * Doc change for azurerm_cognitive_deployment.model.format * Change azurerm_batch_pool doc EOLs * Change azurerm_batch_pool doc EOLs * Reformat example hcl template * Update cognitive deployment format validation and documentation

* Update CHANGELOG.md hashicorp#29285, hashicorp#29294 * Update CHANGELOG.md for hashicorp#29307 * Update CHANGELOG.md hashicorp#29283 * Update CHANGELOG.md hashicorp#29271 * Update CHANGELOG.md hashicorp#29298 * Update CHANGELOG.md hashicorp#29278 * Update CHANGELOG.md hashicorp#29341 * Update CHANGELOG.md hashicorp#29328 * Update CHANGELOG.md hashicorp#29292 * Update CHANGELOG.md hashicorp#29361 * Update CHANGELOG.md hashicorp#29296 * Update CHANGELOG.md hashicorp#28239 * Update CHANGELOG.md hashicorp#28974 * Update CHANGELOG.md hashicorp#29254 * Update CHANGELOG.md hashicorp#29333 * Update CHANGELOG.md hashicorp#29314 * Update CHANGELOG.md hashicorp#28929 * Update CHANGELOG.md for hashicorp#29382 * Update for hashicorp#28676 * Update CHANGELOG.md for hashicorp#28740 * Update CHANGELOG.md for hashicorp#28559 * Update CHANGELOG.md hashicorp#29143 * Update CHANGELOG.md hashicorp#29329 * Update CHANGELOG.md hashicorp#29380 * Update CHANGELOG.md hashicorp#29309 * Update CHANGELOG.md hashicorp#29317 * prep for release --------- Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: kt <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: jackofallops <[email protected]>

github-actions · 2025-05-24T02:19:53Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

liuwuliuyun added 3 commits March 20, 2025 18:30

Support other format in azurerm_cognitive_deployments

00fcf2c

Doc change for azurerm_cognitive_deployment.model.format

8a2712e

Change azurerm_batch_pool doc EOLs

62814d6

github-actions bot added documentation service/cognitive-services size/XS labels Mar 21, 2025

liuwuliuyun changed the title ~~azurerm_cognitive_deployment - Remove limitation on model.format~~ azurerm_cognitive_deployment - Change validation function on model.format Mar 21, 2025

liuwuliuyun changed the title ~~azurerm_cognitive_deployment - Change validation function on model.format~~ azurerm_cognitive_deployment - change validation function on model.format Mar 21, 2025

github-actions bot added the enhancement label Mar 21, 2025

liuwuliuyun marked this pull request as ready for review March 21, 2025 06:29

liuwuliuyun requested a review from a team as a code owner March 21, 2025 06:29

Change azurerm_batch_pool doc EOLs

5074e64

github-actions bot added the waiting-response label Mar 21, 2025

Reformat example hcl template

4c1f3d6

github-actions bot removed the waiting-response label Mar 21, 2025

catriona-m requested changes Mar 24, 2025

View reviewed changes

github-actions bot assigned catriona-m Mar 24, 2025

github-actions bot added the waiting-response label Mar 24, 2025

github-actions bot removed the waiting-response label Mar 26, 2025

liuwuliuyun requested a review from catriona-m March 31, 2025 07:23

katbyte previously requested changes Apr 21, 2025

View reviewed changes

github-actions bot assigned katbyte Apr 21, 2025

github-actions bot added the waiting-response label Apr 21, 2025

Update cognitive deployment format validation and documentation

4927d21

github-actions bot removed the waiting-response label Apr 22, 2025

liuwuliuyun requested a review from katbyte April 22, 2025 05:19

catriona-m approved these changes Apr 23, 2025

View reviewed changes

catriona-m merged commit a583590 into hashicorp:main Apr 23, 2025
33 checks passed

github-actions bot added this to the v4.27.0 milestone Apr 23, 2025

catriona-m added a commit that referenced this pull request Apr 23, 2025

Update CHANGELOG.md #29143

12a0c69

github-actions bot locked as resolved and limited conversation to collaborators May 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_cognitive_deployment` - change validation function on `model.format`#29143

`azurerm_cognitive_deployment` - change validation function on `model.format`#29143
catriona-m merged 6 commits intohashicorp:mainfrom
liuwuliuyun:fix-29117

liuwuliuyun commented Mar 21, 2025 •

edited

Loading

Uh oh!

catriona-m left a comment

Uh oh!

liuwuliuyun commented Mar 26, 2025

Uh oh!

katbyte left a comment

Uh oh!

liuwuliuyun commented Apr 22, 2025

Uh oh!

catriona-m left a comment

Uh oh!

Uh oh!

github-actions bot commented May 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

liuwuliuyun commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

liuwuliuyun commented Mar 26, 2025

Uh oh!

katbyte left a comment

Choose a reason for hiding this comment

Uh oh!

liuwuliuyun commented Apr 22, 2025

Uh oh!

catriona-m left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

liuwuliuyun commented Mar 21, 2025 •

edited

Loading