`azurerm_mssql_managed_instance_failover_group`: add property `secondary_type` by wyattfry · Pull Request #28633 · hashicorp/terraform-provider-azurerm

wyattfry · 2025-01-29T21:12:52Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

azurerm_mssql_managed_instance_failover_group: add property secondary_type, possible values are Geo and Standby

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevant documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_mssql_managed_instance_failover_group: add property secondary_type [azurerm_mssql_managed_instance_failover_group: add property secondary_type #28633]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #26104

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

website/docs/r/mssql_managed_instance_failover_group.html.markdown

sreallymatt

Thanks @wyattfry, I've left a few comments inline if you wouldn't mind reviewing those!

internal/services/mssqlmanagedinstance/mssql_managed_instance_failover_group_resource.go

internal/services/mssqlmanagedinstance/mssql_managed_instance_failover_group_resource_test.go

website/docs/r/mssql_managed_instance_failover_group.html.markdown

…failover_group_resource.go Co-authored-by: sreallymatt <[email protected]>

sreallymatt

Provided the tests are still passing after these changes, LGTM

…r-azurerm into wyatt/mssql-managed-instance-secondary-type

wyattfry · 2025-02-07T16:22:28Z

Provided the tests are still passing after these changes, LGTM

doing one last test run with the latest master

* CHANGELOG.md for v4.19.0 * Update CHANGELOG.md #28523 * Update CHANGELOG.md #28691 * Updated to include #28717 * Update for #26680 * Update CHANGELOG.md #28633 * Update CHANGELOG.md for #28703 * Update CHANGELOG.md for #28391 * Update CHANGELOG.md #28725 * Update #28733 * Update CHANGELOG.md #28659 * Update for #28741 * Update CHANGELOG.md #28712 * Update CHANGELOG.md #28441 * Update CHANGELOG.md #28441 * Update CHANGELOG.md #28441 * Update CHANGELOG.md for #28602 * Update for #27424 * Update CHANGELOG.md for #28524 * Update CHANGELOG.md #28726 * Update for #28767 * Update for #28195 * prep for release v4.19.0 --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Wodans Son <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>

…ary_type` (hashicorp#28633) * wip adding prop secondary_type * docs update * add suffix to test resources * docs update * clean up * fmt docs * defined default value * use pet names * Update internal/services/mssqlmanagedinstance/mssql_managed_instance_failover_group_resource.go Co-authored-by: sreallymatt <[email protected]> * Apply suggestions from code review Co-authored-by: sreallymatt <[email protected]> * pet removal * feedback * feedback * fmt * undo unnecessary change * fmt --------- Co-authored-by: sreallymatt <[email protected]>

* CHANGELOG.md for v4.19.0 * Update CHANGELOG.md hashicorp#28523 * Update CHANGELOG.md hashicorp#28691 * Updated to include hashicorp#28717 * Update for hashicorp#26680 * Update CHANGELOG.md hashicorp#28633 * Update CHANGELOG.md for hashicorp#28703 * Update CHANGELOG.md for hashicorp#28391 * Update CHANGELOG.md hashicorp#28725 * Update hashicorp#28733 * Update CHANGELOG.md hashicorp#28659 * Update for hashicorp#28741 * Update CHANGELOG.md hashicorp#28712 * Update CHANGELOG.md hashicorp#28441 * Update CHANGELOG.md hashicorp#28441 * Update CHANGELOG.md hashicorp#28441 * Update CHANGELOG.md for hashicorp#28602 * Update for hashicorp#27424 * Update CHANGELOG.md for hashicorp#28524 * Update CHANGELOG.md hashicorp#28726 * Update for hashicorp#28767 * Update for hashicorp#28195 * prep for release v4.19.0 --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Wodans Son <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: jackofallops <[email protected]>

github-actions · 2025-03-11T02:15:08Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

wip adding prop secondary_type

614d474

github-actions bot added service/mssqlmanagedinstance size/XS labels Jan 29, 2025

docs update

f1773c0

github-actions bot added the documentation label Jan 29, 2025

wyattfry commented Jan 29, 2025

View reviewed changes

website/docs/r/mssql_managed_instance_failover_group.html.markdown Outdated Show resolved Hide resolved

wyattfry marked this pull request as ready for review January 30, 2025 13:28

wyattfry requested a review from a team as a code owner January 30, 2025 13:28

jackofallops self-assigned this Jan 30, 2025

add suffix to test resources

d26df55

github-actions bot added size/S and removed size/XS labels Jan 30, 2025

docs update

14ae87f

github-actions bot added size/XL waiting-response and removed size/S labels Jan 31, 2025

clean up

307c413

github-actions bot added size/L waiting-response and removed waiting-response size/XL labels Jan 31, 2025

fmt docs

6c73d5b

github-actions bot removed the waiting-response label Jan 31, 2025

defined default value

f151066

github-actions bot added the waiting-response label Jan 31, 2025

use pet names

784a944

github-actions bot removed the waiting-response label Jan 31, 2025

sreallymatt reviewed Feb 3, 2025

View reviewed changes

github-actions bot added the waiting-response label Feb 3, 2025

Update internal/services/mssqlmanagedinstance/mssql_managed_instance_…

5e5aebf

…failover_group_resource.go Co-authored-by: sreallymatt <[email protected]>

github-actions bot added waiting-response and removed waiting-response labels Feb 4, 2025

wyattfry requested a review from sreallymatt February 4, 2025 13:38

fmt

ded4443

github-actions bot removed the waiting-response label Feb 4, 2025

jackofallops assigned sreallymatt and unassigned jackofallops Feb 4, 2025

sreallymatt previously approved these changes Feb 5, 2025

View reviewed changes

undo unnecessary change

b853c77

wyattfry dismissed sreallymatt’s stale review via b853c77 February 6, 2025 18:05

wyattfry requested a review from sreallymatt February 6, 2025 18:06

sreallymatt previously approved these changes Feb 6, 2025

View reviewed changes

Merge branch 'main' of https://github.com/hashicorp/terraform-provide…

86786e5

…r-azurerm into wyatt/mssql-managed-instance-secondary-type

github-actions bot added the waiting-response label Feb 7, 2025

fmt

195e25c

wyattfry dismissed sreallymatt’s stale review via 195e25c February 7, 2025 21:42

github-actions bot added service/container-apps and removed waiting-response labels Feb 7, 2025

wyattfry requested a review from sreallymatt February 7, 2025 21:51

sreallymatt approved these changes Feb 7, 2025

View reviewed changes

wyattfry merged commit 92bb86b into main Feb 8, 2025
33 checks passed

wyattfry deleted the wyatt/mssql-managed-instance-secondary-type branch February 8, 2025 20:14

github-actions bot added this to the v4.19.0 milestone Feb 8, 2025

wyattfry added a commit that referenced this pull request Feb 10, 2025

Update CHANGELOG.md #28633

7b0cbeb

github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_mssql_managed_instance_failover_group`: add property `secondary_type`#28633

`azurerm_mssql_managed_instance_failover_group`: add property `secondary_type`#28633
wyattfry merged 19 commits intomainfrom
wyatt/mssql-managed-instance-secondary-type

wyattfry commented Jan 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

sreallymatt left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sreallymatt left a comment

Uh oh!

wyattfry commented Feb 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

wyattfry commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

Uh oh!

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sreallymatt left a comment

Choose a reason for hiding this comment

Uh oh!

wyattfry commented Feb 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wyattfry commented Jan 29, 2025 •

edited

Loading