Skip to content

Fix test failure splitting TestAccAWSNetworkAclRule_ipv6VpcAssignGene…#14918

Merged
bflad merged 2 commits intohashicorp:masterfrom
angelabad:td-tests-resource-aws_network_acl_rule
Sep 10, 2020
Merged

Fix test failure splitting TestAccAWSNetworkAclRule_ipv6VpcAssignGene…#14918
bflad merged 2 commits intohashicorp:masterfrom
angelabad:td-tests-resource-aws_network_acl_rule

Conversation

@angelabad
Copy link
Contributor

@angelabad angelabad commented Aug 30, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14567

Release note for CHANGELOG:

NONE

I created TestSteps to avoid count use.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate -timeout 120m
=== RUN   TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate
=== PAUSE TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate
=== CONT  TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (68.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.409s

@angelabad angelabad requested a review from a team August 30, 2020 20:20
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 30, 2020
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 1, 2020
bflad
bflad suggested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @angelabad 👋 Thank you for submitting this. Splitting up the configuration to remove the count usage is a great idea, however we will still want the test itself to include the two TestStep in the same test -- this allows us to verify that an in-place update of the assign_generated_ipv6_cidr_block argument from false to true properly updates the resource.

@angelabad
Copy link
Contributor Author

angelabad commented Sep 3, 2020

Thanks @bflad for your comment, I will take a look next week.

@angelabad angelabad force-pushed the td-tests-resource-aws_network_acl_rule branch from 6cd6d3a to c712eec Compare September 10, 2020 15:26
@angelabad angelabad requested a review from bflad September 10, 2020 15:28
bflad
bflad approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @angelabad 🚀

Output from acceptance testing:

--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (48.78s)

@bflad bflad added this to the v3.6.0 milestone Sep 10, 2020
@bflad bflad merged commit 2dbd3dd into hashicorp:master Sep 10, 2020
@ghost
Copy link

ghost commented Sep 11, 2020

This has been released in version 3.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@angelabad angelabad deleted the td-tests-resource-aws_network_acl_rule branch September 25, 2020 07:07
@ghost
Copy link

ghost commented Oct 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bflad bflad bflad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

tests/resource/aws_network_acl_rule: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate Failures

2 participants

@angelabad @bflad