fix: add missing '/-/' path segment to UI URL generation functions#3668
fix: add missing '/-/' path segment to UI URL generation functions#3668ManvithaP-hub wants to merge 1 commit intoharness:mainfrom
Conversation
Fixes harness#3661 The GenerateUIBuildURL, GenerateUIPRURL, GenerateUICompareURL, and GenerateUIRefURL functions were missing the '/-/' path segment that the frontend routing expects, causing incorrect URLs in DRONE_BUILD_LINK environment variables and webhook payloads. Signed-off-by: manvitha92 <[email protected]>
|
|
|
"Hi @harness-maintainers, could someone please review this when you get a chance? This fix: add missing '/-/' path segment to UI URL generation functions#3668. Happy to make any adjustments! |
* feat:[AH-1083]: url fix
|
"Hi @harness-maintainers, could someone please review this when you get a chance? This fix: add missing '/-/' path segment to UI URL generation functions#3668. Happy to make any adjustments! |
|
Hi @harness-maintainers, could someone please review this when you get a chance? This fix: add missing '/-/' path segment to UI URL generation functions#3668. Happy to make any adjustments! |
2 participants
What this PR does
Fixes incorrect UI URLs generated by the backend in
app/url/provider.go.Problem
Four URL generation functions were missing the
/-/path segment thatthe frontend routing expects, causing broken links in:
DRONE_BUILD_LINKenvironment variable in pipeline executionsGenerateUIBuildURL/{repoPath}/pipelines/.../{repoPath}/-/pipelines/...GenerateUIPRURL/{repoPath}/pulls/.../{repoPath}/-/pulls/...GenerateUICompareURL/{repoPath}/pulls/compare/.../{repoPath}/-/pulls/compare/...GenerateUIRefURL/{repoPath}/commit/.../{repoPath}/-/commit/...Fix
Added
"-"as a path segment to all fourGenerateUI*URLfunctionsin
app/url/provider.goand updated the corresponding test expectationsin
app/url/provider_test.go.Fixes #3661