Skip to content

Update deployment ID to bigint#3613

Open
maxknee wants to merge 5 commits intoharness:dronefrom
maxknee:build-id-bigint
Open

Update deployment ID to bigint#3613
maxknee wants to merge 5 commits intoharness:dronefrom
maxknee:build-id-bigint

Conversation

@maxknee
Copy link
Copy Markdown

@maxknee maxknee commented Jan 28, 2025

We're using github deployments and the ID is out of range:

{"message":"pq: value \"2148060640\" is out of range for type integer"}

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 28, 2025

CLA assistant check
All committers have signed the CLA.

@vistaarjuneja
Copy link
Copy Markdown
Contributor

hi @maxknee , thanks for the PR! We'd want this added for other databases as well (mysql, sqlite) - are any changes required there?

@maxknee
Copy link
Copy Markdown
Author

maxknee commented Jan 29, 2025 via email

Signed-off-by: Max Knee <[email protected]>
@vistaarjuneja
Copy link
Copy Markdown
Contributor

hey @maxknee , curious how you tested this and on which version of postgres? On testing manually, this command doesn't seem to work for ALTER column and we need to instead set them separately (in postgres version 14):

ALTER TABLE builds 
ALTER COLUMN build_deploy_id SET DATA TYPE BIGINT,
ALTER COLUMN build_deploy_id SET NOT NULL,
ALTER COLUMN build_deploy_id SET DEFAULT 0;

@dewan-ahmed
Copy link
Copy Markdown
Contributor

Hi @maxknee please make changes based on the feedback. If there's no activity, we'll close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants