Open
Conversation
Signed-off-by: Max Knee <[email protected]>
Contributor
|
hi @maxknee , thanks for the PR! We'd want this added for other databases as well (mysql, sqlite) - are any changes required there? |
Author
|
I'll make those changes
…On Wed, Jan 29, 2025, 5:18 PM Vistaar Juneja ***@***.***> wrote:
hi @maxknee <https://github.com/maxknee> , thanks for the PR! We'd want
this added for other databases as well (mysql, sqlite) - are any changes
required there?
—
Reply to this email directly, view it on GitHub
<#3613 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABVGWGML5NHYY5XVM2WC6D2NFHTHAVCNFSM6AAAAABWAR3CWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRSHE4DONJXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: Max Knee <[email protected]>
Contributor
|
hey @maxknee , curious how you tested this and on which version of postgres? On testing manually, this command doesn't seem to work for ALTER column and we need to instead set them separately (in postgres version 14): |
Contributor
|
Hi @maxknee please make changes based on the feedback. If there's no activity, we'll close the PR. |
Signed-off-by: Max Knee <[email protected]>
Signed-off-by: Max Knee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using github deployments and the ID is out of range: