Support node v18 and hapi v21, drop node v12 and hapi v18/19#322
Merged
devinivy merged 7 commits intohapijs:masterfrom Aug 8, 2022
Merged
Support node v18 and hapi v21, drop node v12 and hapi v18/19#322devinivy merged 7 commits intohapijs:masterfrom
devinivy merged 7 commits intohapijs:masterfrom
Conversation
Member
geek
commented
Jul 18, 2022
geek
commented
- Support and test on hapi v21, drop support for hapi v19.
- Test ESM support.
geek
added
feature
devinivy
reviewed
Jul 19, 2022
Member
|
@geek The failing tests are due to DNS resolution changes in node v18, in the same vein as hapijs/hapi#4357. If you merge this work into your PR I think they should be resolved: geek/nes@v21-hapi...hapijs:nes:fix-node-v18-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.