Fix handling of no remoteAddress available#4396
Merged
devinivy merged 3 commits intohapijs:masterfrom Dec 1, 2022
joshkel:remote-addr-gone
Merged
Fix handling of no remoteAddress available#4396devinivy merged 3 commits intohapijs:masterfrom joshkel:remote-addr-gone
devinivy merged 3 commits intohapijs:masterfrom
joshkel:remote-addr-gone
Conversation
DJMcK
reviewed
Nov 19, 2022
Contributor
DJMcK
left a comment
There was a problem hiding this comment.
Thanks for working on this, @joshkel! Experiencing the same exception accessing request.info.remoteAddress which brought me here.
Not a core maintainer so take my suggestions with a pinch of salt :)
FWIW, I'm not entirely convinced that there is a need to go through the whole rigmarole of creating a connection and destroying it for this case.
We could just simplify things down to something along the lines of:
it('handles when client address is undefined', async () => {
const server = Hapi.server();
server.route({
method: 'get',
path: '/',
handler(request) {
delete request.raw.req.socket.remoteAddress;
return request.info.remoteAddress === undefined;
}
});
const { result } = await server.inject('/');
expect(result).to.equal(true);
});I believe delete should be safe to use in this scenario.
Contributor
Member
|
This looks pretty dang close— I should be able to land this within the next 24 hours. |
|
@devinivy any updates on when will this be merged? Thank you |
Co-authored-by: David McKeown <[email protected]>
devinivy
reviewed
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4395
I'm unfamiliar with Hapi's test designs; please let me know if the test needs any changes.