Use response instead of request when marshalling#4162
Merged
devinivy merged 5 commits intohapijs:masterfrom Sep 24, 2020
Merged
Use response instead of request when marshalling#4162devinivy merged 5 commits intohapijs:masterfrom
devinivy merged 5 commits intohapijs:masterfrom
Conversation
devinivy
reviewed
Sep 23, 2020
devinivy
approved these changes
Sep 23, 2020
Member
devinivy
left a comment
devinivy
left a comment
There was a problem hiding this comment.
Left one open question/comment that I wouldn't mind another set of eyes on, but this looks great. Thanks for the speedy fix.
cjihrig
approved these changes
Sep 23, 2020
|
Wow, you are great! Thanks a lot! 😊 |
nlf
requested changes
Sep 23, 2020
Member
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
this change makes sense to me, i think the test leaves a little bit to be desired though. it's worth asserting that the response event is the client aborted event we expect it to be.
once that's done this is a 👍 from me
devinivy
approved these changes
Sep 23, 2020
Nargonath
added a commit
that referenced
this pull request
Oct 28, 2020
* update handlebars dependency version handlebars is only a devDependency, but update the version due to a security advisory. Refs: GHSA-q2c6-c6pm-g3gh * docs: ✏️ improve docs for server.rules() (#4141) * docs: ✏️ improve docs for server.rules() server.rules() was missing a good example and explanation was a bit obscure. * docs: ✏️ update requested changes for route rules Co-authored-by: Danilo Alonso <[email protected]> * Use response instead of request when marshalling (#4162) * Use response instead of request when marshalling. Closes #4161 * Cleanup * Don't change internals.fail() * Fix info.responding being set on remotely closed requests * More cleanup * 20.0.1 * upgrade to labv24 (#4167) * Update joi documentation link (#4174) Co-authored-by: cjihrig <[email protected]> Co-authored-by: Danilo Alonso <[email protected]> Co-authored-by: Danilo Alonso <[email protected]> Co-authored-by: Gil Pedersen <[email protected]> Co-authored-by: Devin Ivy <[email protected]> Co-authored-by: Lloyd Benson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proper fix for the issue in #4161. Also includes a failing test.