fixed teamwork version#4130
Merged
cjihrig merged 3 commits intohapijs:masterfrom Aug 11, 2020
irshad437:master
Merged
Conversation
cjihrig
approved these changes
Jul 31, 2020
imcodingideas
approved these changes
Aug 10, 2020
Contributor
|
@irshad437 sorry, but this has a conflict. Would you mind resolving that so that your change can land and be released in hapi v20? |
Contributor
Author
|
Hi @cjihrig , I had resolved the conflicts but the build fails. I am unable to understand the reason. Could you please help me here? |
Contributor
|
It seems to be unrelated, as a restart of the test https://travis-ci.org/github/hapijs/hapi/jobs/716867430 cleared the issue. |
Contributor
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was using a deprecated version of teamwork which was leaving it unable to use. I've updated the version.