support JSON.stringify() of request.info#4020
Merged
hueniverse merged 1 commit intohapijs:masterfrom Jan 10, 2020
cjihrig:tojson
Merged
support JSON.stringify() of request.info#4020hueniverse merged 1 commit intohapijs:masterfrom cjihrig:tojson
hueniverse merged 1 commit intohapijs:masterfrom
cjihrig:tojson
Conversation
This commit adds a toJSON() method to the class used to create request.info. This ensures that request.info can be safely stringified in the presence of circular data structures. Fixes: #4019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a
toJSON()method to the class used to createrequest.info. This ensures thatrequest.infocan be safely stringified in the presence of circular data structures.Fixes: #4019