explicitly destroy sockets on clientError#3461
Merged
hueniverse merged 1 commit intomasterfrom May 30, 2017
Merged
Conversation
node versions >= 6 no longer destroy sockets by default when a clientError listener is attached, we have to do so ourselves
Member
|
Good catch. Is that well-documented anywhere? I wonder if it will help fix server hangs, i.e. in #3290. Also– no problem with this code "re-destroying" the socket for node v4 and v5? |
Member
Author
|
kind of? https://nodejs.org/api/http.html#http_event_clienterror click the little "history" arrow |
Member
Author
|
and no, the destroy() method returns early if the socket is already destroyed |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node versions >= 6 no longer destroy sockets by default when a clientError listener is attached, we have to do so ourselves