Failing test for server.ext with complex deps.#2642
Merged
hueniverse merged 6 commits intohapijs:masterfrom Jul 29, 2015
Merged
Failing test for server.ext with complex deps.#2642hueniverse merged 6 commits intohapijs:masterfrom
server.ext with complex deps.#2642hueniverse merged 6 commits intohapijs:masterfrom
Conversation
Contributor
|
Can you rewrite this test not to change existing tests? Just add a new |
Member
Author
|
Should be resolved now! |
test/plugin.js
Outdated
Contributor
There was a problem hiding this comment.
Don't use the internals plugin here. Create three new ones inside the test.
Member
Author
There was a problem hiding this comment.
Makes sense, given what you said. I made those updates for you.
hueniverse
pushed a commit
that referenced
this pull request
Jul 29, 2015
Failing test for `server.ext` with complex deps.
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
server.extoptionbeforeas an array misbehaves, essentially ignoring the dependencies.Root cause in topo has a pending PR: hapijs/topo#7. I've verified that patching topo allows all tests to pass.