Merged
Conversation
Contributor
|
Removing the fix does not break the test. |
Contributor
Author
|
@hueniverse Are you sure? I just checked on master and it still fails for me. FYI, I'm on node v0.10.36 on Yosemite. |
Contributor
Author
|
@hueniverse I can see you have made your own fix, which is probably wise. However it has issues on node 0.10 as seen in this travis log: https://travis-ci.org/hapijs/hapi/jobs/53393303 It seems your fix requires streams3 for full support. |
Contributor
|
@kanongil yeah, I need to find a way around that to first drain the stream. Have been busy with other stuff. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a new test that fails on all version of node.
I'm not entirely sure that the fix I have implemented is the best way to handle this issue but it seems to do the trick without messing up any other tests.